Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [patch] fix issues in some locales with using a-z
Date: Fri, 23 Jun 2006 00:06:00 -0000	[thread overview]
Message-ID: <200606221950.22456.vapier@gentoo.org> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 878 bytes --]

hmm, lets try this again but with a patch that doesnt break Makefile.in

a bunch of files in gdb use a-z in sed expressions without forcing the locale 
to c ... in some locales, this can cause some pretty "fun" results:

(observer.sh)
In file included from solib.c:47:
observer.h:35: error: stray '@' in program
observer.h:35: error: expected ')' before 'deftypefun'

(Makefile.in:init.c)
libgdb.a(init.o): In function `initialize_all_files':
init.c:(.text+0xa): undefined reference to `_initialize_amd64_lin'
init.c:(.text+0xf): undefined reference to `_initialize_i386_'

i've fixed this issue in the Makefile.in, gdb_indent.sh, gdb_mbuild,sh, and 
observer.sh files the same way that gdbarch.sh was fixed oh-so-long ago 
rather than the over-the-top way that autoconf does it (see the top of 
gdb/configure under "NLS nuisances" to see what i mean)
-mike

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: gdb-locale.patch --]
[-- Type: text/x-diff, Size: 1439 bytes --]

2006-06-22  Mike Frysinger  <vapier@gentoo.org>:

	* Makefile.in (init.c) [LANG, LC_ALL]: Set to `c'.
	* gdb_indent.sh, gdb_mbuild.sh, observer.sh: Likewise

--- gdb/Makefile.in
+++ gdb/Makefile.in
@@ -1154,6 +1154,8 @@ init.c: $(INIT_FILES)
 	@rm -f init.c-tmp init.l-tmp
 	@touch init.c-tmp
 	@echo gdbtypes > init.l-tmp
+	@-LANG=c ; export LANG ; \
+	LC_ALL=c ; export LC_ALL ; \
-	@-echo $(INIT_FILES) | \
+	echo $(INIT_FILES) | \
 	tr ' ' '\012' | \
 	sed \
--- gdb/gdb_indent.sh
+++ gdb/gdb_indent.sh
@@ -3,6 +3,11 @@
 # Try to find a GNU indent.  There could be a BSD indent in front of a
 # GNU gindent so when indent is found, keep looking.
 
+# Make certain that the script is running in an internationalized
+# environment.
+LANG=c ; export LANG
+LC_ALL=c ; export LC_ALL
+
 gindent=
 indent=
 paths=`echo $PATH | sed \
--- gdb/gdb_mbuild.sh
+++ gdb/gdb_mbuild.sh
@@ -22,6 +22,11 @@
 #  Foundation, Inc., 51 Franklin Street, Fifth Floor,
 #  Boston, MA  02111-1301, USA
 
+# Make certain that the script is running in an internationalized
+# environment.
+LANG=c ; export LANG
+LC_ALL=c ; export LC_ALL
+
 usage()
 {
     cat <<EOF
--- gdb/observer.sh
+++ gdb/observer.sh
@@ -1,5 +1,10 @@
 #!/bin/sh -e
 
+# Make certain that the script is running in an internationalized
+# environment.
+LANG=c ; export LANG
+LC_ALL=c ; export LC_ALL
+
 if test $# -ne 3
 then
     echo "Usage: $0 <h|inc> <observer.texi> <observer.out>" 1>&2

             reply	other threads:[~2006-06-23  0:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-23  0:06 Mike Frysinger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-06-22  4:00 Mike Frysinger
2006-07-06 13:32 ` Daniel Jacobowitz
2006-07-06 18:12   ` Mike Frysinger
2006-07-12 18:04     ` Daniel Jacobowitz
2006-07-13  3:48       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606221950.22456.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox