From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5175 invoked by alias); 6 Jul 2006 13:32:58 -0000 Received: (qmail 5167 invoked by uid 22791); 6 Jul 2006 13:32:57 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 06 Jul 2006 13:32:47 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FyTyF-000569-Et; Thu, 06 Jul 2006 09:32:43 -0400 Date: Thu, 06 Jul 2006 13:32:00 -0000 From: Daniel Jacobowitz To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [patch] fix issues in some locales with using a-z Message-ID: <20060706133243.GD18827@nevyn.them.org> Mail-Followup-To: Mike Frysinger , gdb-patches@sourceware.org References: <200606220005.43029.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200606220005.43029.vapier@gentoo.org> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00032.txt.bz2 On Thu, Jun 22, 2006 at 12:05:42AM -0400, Mike Frysinger wrote: > a bunch of files in gdb use a-z in sed expressions without forcing the locale > to c ... in some locales, this can cause some pretty "fun" results: > > (observer.sh) > In file included from solib.c:47: > observer.h:35: error: stray '@' in program > observer.h:35: error: expected ')' before 'deftypefun' > > (Makefile.in:init.c) > libgdb.a(init.o): In function `initialize_all_files': > init.c:(.text+0xa): undefined reference to `_initialize_amd64_lin' > init.c:(.text+0xf): undefined reference to `_initialize_i386_' > > i've fixed this issue in the Makefile.in, gdb_indent.sh, gdb_mbuild,sh, and > observer.sh files the same way that gdbarch.sh was fixed oh-so-long ago > rather than the over-the-top way that autoconf does it (see the top of > gdb/configure under "NLS nuisances" to see what i mean) Tsk tsk. You must not have tested this patch too well; you made the mistake I always make in multi-line Makefile commands: > + LANG=c ; export LANG ; \ > + LC_ALL=c ; export LC_ALL ; \ > @-echo $(INIT_FILES) | \ @ and - are special only on the first command, not if you use backslashes. > +# Make certain that the script is running in an internationalized > +# environment. Don't you really mean "not" here? -- Daniel Jacobowitz CodeSourcery