Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* About decimal floating point support
@ 2006-06-13 15:51 Wu Zhou
  2006-06-13 17:40 ` Daniel Jacobowitz
  0 siblings, 1 reply; 6+ messages in thread
From: Wu Zhou @ 2006-06-13 15:51 UTC (permalink / raw)
  To: drow; +Cc: gdb-patches

Hi Daniel,

We ever talked about adding decimal floating point into GDB.  And you 
provided a lot insightful suggestion for my first patch.  In my post at 
2005-10-18:
  http://sources.redhat.com/ml/gdb-patches/2005-10/msg00148.html
  http://sources.redhat.com/ml/gdb-patches/2005-10/msg00149.html

I revised the patch and the testcase. I believe it can address most of 
your concern.

But there is one concern not addressed: you ever proposed to move 
libdecnumber to the top level of the repository, and use that to implement 
DFP support in GDB.  At that time (Oct, 2005), DFP support for gcc is not 
matured yet.  The libdecnumber code may change itself.  So I didn't bother 
to adopt you method at that time and put my focus on resolving other 
problem you pointed out.  Now since DFP is already in the 4.2 development
tree of gcc.  So I guess it is time to revist this.

What is your current thought about this?  Do you still think it is more 
feasible to put libdecnumber at the top level repository?  I am now 
considering copy the code of libdecnumber (which is at the top level of 
gcc repository) to the top level of gdb repository. and use that to 
re-implment DFP support.  If the code of libdecnumber is changed, we can 
synchronize that to gdb repository.  Then gdb developers don't need to 
maintain these sensitive numeric code.

What do you think on this?  Your comments are highly appreciated!

Regards
- Wu Zhou  


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: About decimal floating point support
  2006-06-13 15:51 About decimal floating point support Wu Zhou
@ 2006-06-13 17:40 ` Daniel Jacobowitz
  2006-06-13 19:02   ` DJ Delorie
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2006-06-13 17:40 UTC (permalink / raw)
  To: Wu Zhou; +Cc: gdb-patches, DJ Delorie

On Tue, Jun 13, 2006 at 11:51:23PM +0800, Wu Zhou wrote:
> What is your current thought about this?  Do you still think it is more 
> feasible to put libdecnumber at the top level repository?  I am now 
> considering copy the code of libdecnumber (which is at the top level of 
> gcc repository) to the top level of gdb repository. and use that to 
> re-implment DFP support.  If the code of libdecnumber is changed, we can 
> synchronize that to gdb repository.  Then gdb developers don't need to 
> maintain these sensitive numeric code.
> 
> What do you think on this?  Your comments are highly appreciated!

I think it's a good idea.

DJ, if we copied libdecnumber to src, would you be able to add it to
your sync scripts?  The src copy would be strictly read-only.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: About decimal floating point support
  2006-06-13 17:40 ` Daniel Jacobowitz
@ 2006-06-13 19:02   ` DJ Delorie
  2006-06-13 19:17     ` Daniel Jacobowitz
  0 siblings, 1 reply; 6+ messages in thread
From: DJ Delorie @ 2006-06-13 19:02 UTC (permalink / raw)
  To: drow; +Cc: woodzltc, gdb-patches


> DJ, if we copied libdecnumber to src, would you be able to add it to
> your sync scripts?  The src copy would be strictly read-only.

If you don't mind that gcc rules control it, and that the merges would
be semi-automatic and mostly blind, sure.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: About decimal floating point support
  2006-06-13 19:02   ` DJ Delorie
@ 2006-06-13 19:17     ` Daniel Jacobowitz
  2006-06-14  1:10       ` Wu Zhou
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2006-06-13 19:17 UTC (permalink / raw)
  To: DJ Delorie; +Cc: woodzltc, gdb-patches

On Tue, Jun 13, 2006 at 03:02:32PM -0400, DJ Delorie wrote:
> 
> > DJ, if we copied libdecnumber to src, would you be able to add it to
> > your sync scripts?  The src copy would be strictly read-only.
> 
> If you don't mind that gcc rules control it, and that the merges would
> be semi-automatic and mostly blind, sure.

I think that's exactly what we'd want.  Thanks!  Assuming we go through
with this, I'll let you know.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: About decimal floating point support
  2006-06-13 19:17     ` Daniel Jacobowitz
@ 2006-06-14  1:10       ` Wu Zhou
  2006-06-14  2:47         ` Daniel Jacobowitz
  0 siblings, 1 reply; 6+ messages in thread
From: Wu Zhou @ 2006-06-14  1:10 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: DJ Delorie, gdb-patches

Thank you, Daniel and DJ!

Now that both of you agree to this method.  I will follow it to revise my 
patches before on my local repository.  Then send them for your review.  

It this ok?

Regards
- Wu Zhou

On Tue, 13 Jun 2006, Daniel Jacobowitz wrote:

> On Tue, Jun 13, 2006 at 03:02:32PM -0400, DJ Delorie wrote:
> > 
> > > DJ, if we copied libdecnumber to src, would you be able to add it to
> > > your sync scripts?  The src copy would be strictly read-only.
> > 
> > If you don't mind that gcc rules control it, and that the merges would
> > be semi-automatic and mostly blind, sure.
> 
> I think that's exactly what we'd want.  Thanks!  Assuming we go through
> with this, I'll let you know.
> 
> -- 
> Daniel Jacobowitz
> CodeSourcery
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: About decimal floating point support
  2006-06-14  1:10       ` Wu Zhou
@ 2006-06-14  2:47         ` Daniel Jacobowitz
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2006-06-14  2:47 UTC (permalink / raw)
  To: gdb-patches

On Wed, Jun 14, 2006 at 09:10:09AM +0800, Wu Zhou wrote:
> Thank you, Daniel and DJ!
> 
> Now that both of you agree to this method.  I will follow it to revise my 
> patches before on my local repository.  Then send them for your review.  
> 
> It this ok?

Absolutely.  Thanks for doing this.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2006-06-14  2:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-13 15:51 About decimal floating point support Wu Zhou
2006-06-13 17:40 ` Daniel Jacobowitz
2006-06-13 19:02   ` DJ Delorie
2006-06-13 19:17     ` Daniel Jacobowitz
2006-06-14  1:10       ` Wu Zhou
2006-06-14  2:47         ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox