Re: [committed] Fix gcore crashes on s390

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Fri, 5 May 2006 21:56:42 -0400
> From: Daniel Jacobowitz <drow@false.org>
> 
> On Fri, May 05, 2006 at 06:32:05PM -0700, David S. Miller wrote:
> > From: "Ulrich Weigand" <uweigand@de.ibm.com>
> > Date: Sat, 6 May 2006 03:18:51 +0200 (CEST)
> > 
> > > since the switch of gcore to use regset_from_core_section, it
> > > crashes on s390, because the regsets we're providing have a
> > > NULL collect_regset function.  Fixed by the patch below.
> > > 
> > > Tested on s390-ibm-linux and s390x-ibm-linux.
> > > Committed to mainline.
> > 
> > Thanks for catching and fixing this.
> > 
> > Hmmm... is this a common omission?
> 
> Apparently :-(
> 
> I see FRV has the same problem.  So does HP-UX, hppa-linux, hppa-bsd,
> m32r, m68k-bsd, m88k, mips64-openbsd, mips-netbsd, powerpc-linux, and
> then I stopped counting.  Oh, and I realize I was looking at the wrong
> fields, so I probably missed some.  I had no idea...

FYI, thhe HP-UX and OpenBSD/NetBSD targets from the list above don't
need the collect_regset functions since they don't implement gcore.
They will probably never need them, since HP-UX and NetBSD can dump
cores using ptrace(2), and I'm working on implementing something
similar on OpenBSD.

Mark