From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10683 invoked by alias); 6 May 2006 08:31:24 -0000 Received: (qmail 10668 invoked by uid 22791); 6 May 2006 08:31:21 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 06 May 2006 08:31:16 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k468TuOc030848; Sat, 6 May 2006 10:29:56 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k468TtVb018383; Sat, 6 May 2006 10:29:55 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k468TtY7022143; Sat, 6 May 2006 10:29:55 +0200 (CEST) Date: Sat, 06 May 2006 08:31:00 -0000 Message-Id: <200605060829.k468TtY7022143@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: davem@davemloft.net, uweigand@de.ibm.com, gdb-patches@sourceware.org In-reply-to: <20060506015642.GB12668@nevyn.them.org> (message from Daniel Jacobowitz on Fri, 5 May 2006 21:56:42 -0400) Subject: Re: [committed] Fix gcore crashes on s390 References: <200605060118.k461IpKO009920@d12av02.megacenter.de.ibm.com> <20060505.183205.74231759.davem@davemloft.net> <20060506015642.GB12668@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00143.txt.bz2 > Date: Fri, 5 May 2006 21:56:42 -0400 > From: Daniel Jacobowitz > > On Fri, May 05, 2006 at 06:32:05PM -0700, David S. Miller wrote: > > From: "Ulrich Weigand" > > Date: Sat, 6 May 2006 03:18:51 +0200 (CEST) > > > > > since the switch of gcore to use regset_from_core_section, it > > > crashes on s390, because the regsets we're providing have a > > > NULL collect_regset function. Fixed by the patch below. > > > > > > Tested on s390-ibm-linux and s390x-ibm-linux. > > > Committed to mainline. > > > > Thanks for catching and fixing this. > > > > Hmmm... is this a common omission? > > Apparently :-( > > I see FRV has the same problem. So does HP-UX, hppa-linux, hppa-bsd, > m32r, m68k-bsd, m88k, mips64-openbsd, mips-netbsd, powerpc-linux, and > then I stopped counting. Oh, and I realize I was looking at the wrong > fields, so I probably missed some. I had no idea... FYI, thhe HP-UX and OpenBSD/NetBSD targets from the list above don't need the collect_regset functions since they don't implement gcore. They will probably never need them, since HP-UX and NetBSD can dump cores using ptrace(2), and I'm working on implementing something similar on OpenBSD. Mark