From: Daniel Jacobowitz <drow@false.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: uweigand@de.ibm.com, gdb-patches@sourceware.org
Subject: Re: [committed] Fix gcore crashes on s390
Date: Sat, 06 May 2006 01:56:00 -0000 [thread overview]
Message-ID: <20060506015642.GB12668@nevyn.them.org> (raw)
In-Reply-To: <20060505.183205.74231759.davem@davemloft.net>
On Fri, May 05, 2006 at 06:32:05PM -0700, David S. Miller wrote:
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> Date: Sat, 6 May 2006 03:18:51 +0200 (CEST)
>
> > since the switch of gcore to use regset_from_core_section, it
> > crashes on s390, because the regsets we're providing have a
> > NULL collect_regset function. Fixed by the patch below.
> >
> > Tested on s390-ibm-linux and s390x-ibm-linux.
> > Committed to mainline.
>
> Thanks for catching and fixing this.
>
> Hmmm... is this a common omission?
Apparently :-(
I see FRV has the same problem. So does HP-UX, hppa-linux, hppa-bsd,
m32r, m68k-bsd, m88k, mips64-openbsd, mips-netbsd, powerpc-linux, and
then I stopped counting. Oh, and I realize I was looking at the wrong
fields, so I probably missed some. I had no idea...
I guess we're going to have to check the collect_regset function
pointer for NULL then. David, would you mind making that change?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-05-06 1:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-06 1:18 Ulrich Weigand
2006-05-06 1:35 ` David S. Miller
2006-05-06 1:56 ` Daniel Jacobowitz [this message]
2006-05-06 6:30 ` David S. Miller
2006-05-06 15:16 ` Daniel Jacobowitz
2006-05-06 8:31 ` Mark Kettenis
2006-05-06 8:26 ` Mark Kettenis
2006-05-06 15:19 ` Daniel Jacobowitz
2006-05-06 18:29 ` Mark Kettenis
2006-05-06 23:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060506015642.GB12668@nevyn.them.org \
--to=drow@false.org \
--cc=davem@davemloft.net \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox