From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21176 invoked by alias); 6 May 2006 01:56:49 -0000 Received: (qmail 21023 invoked by uid 22791); 6 May 2006 01:56:49 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 06 May 2006 01:56:47 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FcC2E-0003O6-56; Fri, 05 May 2006 21:56:42 -0400 Date: Sat, 06 May 2006 01:56:00 -0000 From: Daniel Jacobowitz To: "David S. Miller" Cc: uweigand@de.ibm.com, gdb-patches@sourceware.org Subject: Re: [committed] Fix gcore crashes on s390 Message-ID: <20060506015642.GB12668@nevyn.them.org> Mail-Followup-To: "David S. Miller" , uweigand@de.ibm.com, gdb-patches@sourceware.org References: <200605060118.k461IpKO009920@d12av02.megacenter.de.ibm.com> <20060505.183205.74231759.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060505.183205.74231759.davem@davemloft.net> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00137.txt.bz2 On Fri, May 05, 2006 at 06:32:05PM -0700, David S. Miller wrote: > From: "Ulrich Weigand" > Date: Sat, 6 May 2006 03:18:51 +0200 (CEST) > > > since the switch of gcore to use regset_from_core_section, it > > crashes on s390, because the regsets we're providing have a > > NULL collect_regset function. Fixed by the patch below. > > > > Tested on s390-ibm-linux and s390x-ibm-linux. > > Committed to mainline. > > Thanks for catching and fixing this. > > Hmmm... is this a common omission? Apparently :-( I see FRV has the same problem. So does HP-UX, hppa-linux, hppa-bsd, m32r, m68k-bsd, m88k, mips64-openbsd, mips-netbsd, powerpc-linux, and then I stopped counting. Oh, and I realize I was looking at the wrong fields, so I probably missed some. I had no idea... I guess we're going to have to check the collect_regset function pointer for NULL then. David, would you mind making that change? -- Daniel Jacobowitz CodeSourcery