Re: [PATCH] Fix spurious mi-basics.exp failures

[Bob Rossi <bob_rossi@cox.net>]

On Fri, May 05, 2006 at 09:52:10PM -0400, Daniel Jacobowitz wrote:
> On Sat, May 06, 2006 at 03:19:32AM +0200, Ulrich Weigand wrote:
> > Hello,
> > 
> > I'm seeing some FAILs in the mi-basics test case.  They're apparently
> > caused by the expected output regexps in some of the mi_gdb_test
> > statements lacking the 'serial number' the MI output lines start with.
> > 
> > Most mi_gdb_test statments already contain that number, but the 202,
> > 203, and 208 tests don't have it.  Those are exactly the tests that
> > fail for me.  Adding the numbers fixes the test.
> > 
> > Tested on s390-ibm-linux and s390x-ibm-linux.
> > OK for mainline?
> > 
> > 
> > ChangeLog:
> > 
> > 	* gdb.mi/mi-basics.exp: Add missing serial number to 
> > 	expected output in some mi_gdb_test statements.
> > 	* gdb.mi/mi2-basics.exp: Likewise.
> 
> Are you sure you tested these in the same build tree where they were
> broken?
> 
> I might be misremembering, but when these tests were added, I think I
> complained about the regexps: they fail when the srcdir is specified
> using a relative path, but succeed with an absolute path, or the other
> way round.
> 
> 203-environment-directory
> 203^done,source-path="/big/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd"
> (gdb) 
> PASS: gdb.mi/mi-basics.exp: environment-directory empty-string
> operation
> 
> Then again, my log does seem to match your results... I don't remember
> these failing on this machine before.
> 
> >From my previous system, an old test run passed with the anchors:
> 
> 202-environment-directory /big/fsf/commit/src/gdb/testsuite/gdb.mi
> 202^done,source-path="/big/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd"
> (gdb) 
> PASS: gdb.mi/mi-basics.exp: environment-directory arg operation
> 203-environment-directory
> 203^done,source-path="/big/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd"
> (gdb) 
> PASS: gdb.mi/mi-basics.exp: environment-directory empty-string operation
> 
> 
> >From today:
> 202-environment-directory /space/fsf/commit/src/gdb/testsuite/gdb.mi
> 202^done,source-path="/space/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd"
> (gdb)
> FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation
> 203-environment-directory
> 203^done,source-path="/space/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd"
> (gdb)
> FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation
> 
> 
> Oh, I bet I know what's happened!  These are the three tests that
> failed based on relative srcdirs or something like that.  So when Bob
> committed fixes to the MI testsuite which added anchoring to
> mi_gdb_test, they probably failed for him both before and after, and
> that's how they were missed.
> 
> Bob, does that sound reasonable?  If so, the patch is OK, and thanks!

I can't think of exactly how the anchoring would have just anything
related to these tests.  I'm just wondering, what fixed the 
relative/absolute path problem?

This is what I got from what I just ran,
202-environment-directory ../../../src/gdb/testsuite/gdb.mi^M 202^done,source-path="/home/bob/cvs/gdb/original/builddir/gdb/testsuite/../../../src/gdb/testsuite/gdb.mi:$cdir:$cwd"^M
(gdb) ^M
FAIL: environment-directory arg operation
203-environment-directory^M
203^done,source-path="/home/bob/cvs/gdb/original/builddir/gdb/testsuite/../../../src/gdb/testsuite/gdb.mi:$cdir:$cwd"^M
(gdb) ^M
FAIL: environment-directory empty-string operation

Bob Rossi