From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Fix spurious mi-basics.exp failures
Date: Sat, 06 May 2006 01:19:00 -0000 [thread overview]
Message-ID: <200605060119.k461JWLU010082@d12av02.megacenter.de.ibm.com> (raw)
Hello,
I'm seeing some FAILs in the mi-basics test case. They're apparently
caused by the expected output regexps in some of the mi_gdb_test
statements lacking the 'serial number' the MI output lines start with.
Most mi_gdb_test statments already contain that number, but the 202,
203, and 208 tests don't have it. Those are exactly the tests that
fail for me. Adding the numbers fixes the test.
Tested on s390-ibm-linux and s390x-ibm-linux.
OK for mainline?
ChangeLog:
* gdb.mi/mi-basics.exp: Add missing serial number to
expected output in some mi_gdb_test statements.
* gdb.mi/mi2-basics.exp: Likewise.
Index: gdb/testsuite/gdb.mi/mi-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-basics.exp,v
retrieving revision 1.12
diff -c -p -r1.12 mi-basics.exp
*** gdb/testsuite/gdb.mi/mi-basics.exp 27 Sep 2005 22:39:01 -0000 1.12
--- gdb/testsuite/gdb.mi/mi-basics.exp 6 May 2006 00:55:38 -0000
*************** proc test_dir_specification {} {
*** 160,170 ****
set envirodir [string_to_regexp ${srcdir}/${subdir}]
mi_gdb_test "202-environment-directory ${srcdir}/${subdir}" \
! "\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory arg operation"
mi_gdb_test "203-environment-directory" \
! "\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory empty-string operation"
mi_gdb_test "204-environment-directory -r" \
--- 160,170 ----
set envirodir [string_to_regexp ${srcdir}/${subdir}]
mi_gdb_test "202-environment-directory ${srcdir}/${subdir}" \
! "202\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory arg operation"
mi_gdb_test "203-environment-directory" \
! "203\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory empty-string operation"
mi_gdb_test "204-environment-directory -r" \
*************** proc test_path_specification {} {
*** 223,229 ****
"environment-path no-args operation"
mi_gdb_test "208-environment-path $srcdir $objdir" \
! "\\\^done,path=\"$escapedsrcdir.$escapedobjdir.$orig_path\"" \
"environment-path dir1 dir2 operation"
mi_gdb_test "209-environment-path -r $objdir" \
--- 223,229 ----
"environment-path no-args operation"
mi_gdb_test "208-environment-path $srcdir $objdir" \
! "208\\\^done,path=\"$escapedsrcdir.$escapedobjdir.$orig_path\"" \
"environment-path dir1 dir2 operation"
mi_gdb_test "209-environment-path -r $objdir" \
Index: gdb/testsuite/gdb.mi/mi2-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-basics.exp,v
retrieving revision 1.4
diff -c -p -r1.4 mi2-basics.exp
*** gdb/testsuite/gdb.mi/mi2-basics.exp 27 Sep 2005 22:39:03 -0000 1.4
--- gdb/testsuite/gdb.mi/mi2-basics.exp 6 May 2006 00:55:38 -0000
*************** proc test_dir_specification {} {
*** 161,171 ****
set envirodir [string_to_regexp ${srcdir}/${subdir}]
mi_gdb_test "202-environment-directory ${srcdir}/${subdir}" \
! "\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory arg operation"
mi_gdb_test "203-environment-directory" \
! "\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory empty-string operation"
mi_gdb_test "204-environment-directory -r" \
--- 161,171 ----
set envirodir [string_to_regexp ${srcdir}/${subdir}]
mi_gdb_test "202-environment-directory ${srcdir}/${subdir}" \
! "202\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory arg operation"
mi_gdb_test "203-environment-directory" \
! "203\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory empty-string operation"
mi_gdb_test "204-environment-directory -r" \
*************** proc test_path_specification {} {
*** 226,232 ****
"environment-path no-args operation"
mi_gdb_test "208-environment-path $srcdir $objdir" \
! "\\\^done,path=\"$escapedsrcdir.$escapedobjdir.$orig_path\"" \
"environment-path dir1 dir2 operation"
mi_gdb_test "209-environment-path -r $objdir" \
--- 226,232 ----
"environment-path no-args operation"
mi_gdb_test "208-environment-path $srcdir $objdir" \
! "208\\\^done,path=\"$escapedsrcdir.$escapedobjdir.$orig_path\"" \
"environment-path dir1 dir2 operation"
mi_gdb_test "209-environment-path -r $objdir" \
--
Dr. Ulrich Weigand
Linux on zSeries Development
Ulrich.Weigand@de.ibm.com
next reply other threads:[~2006-05-06 1:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-06 1:19 Ulrich Weigand [this message]
2006-05-06 1:28 ` Bob Rossi
2006-05-06 1:52 ` Daniel Jacobowitz
2006-05-06 2:02 ` Bob Rossi
2006-05-06 4:08 ` Daniel Jacobowitz
2006-05-06 16:57 ` Ulrich Weigand
2006-05-06 19:52 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605060119.k461JWLU010082@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox