From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: single-step breakpoints
Date: Mon, 01 May 2006 13:54:00 -0000 [thread overview]
Message-ID: <20060501135452.GA1677@nevyn.them.org> (raw)
In-Reply-To: <200604292314.k3TNE3uH012648@elgar.sibelius.xs4all.nl>
On Sun, Apr 30, 2006 at 01:14:03AM +0200, Mark Kettenis wrote:
> Yes, erroring out is defenitely a better approach than warn and have
> things run away. Here's a patch and some adjustments to the testsuite
> to prevent the tests from going into an infinite loop.
>
> ok?
>
>
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * breakpoint.c (insert_single_step_breakpoint): Make a failure to
> insert a single-step breakpoint an error instead of a warning.
>
> * breakpoint.c (remove_single_step_breakpoints): Bail out early if
> no breakpoints are inserted.
Yeah, I think this is OK.
Ideally, of course, we wouldn't error here. But I'm not sure what
would be more sensible to do. We could quietly finish instead, but
that would go more than one instruction - quite bad.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-05-01 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 20:40 Mark Kettenis
2006-04-25 21:02 ` Daniel Jacobowitz
2006-04-25 21:55 ` Mark Kettenis
2006-04-30 3:20 ` Mark Kettenis
2006-05-01 13:54 ` Daniel Jacobowitz [this message]
2006-05-01 16:43 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060501135452.GA1677@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox