Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: single-step breakpoints
Date: Tue, 25 Apr 2006 21:02:00 -0000	[thread overview]
Message-ID: <20060425210200.GA1153@nevyn.them.org> (raw)
In-Reply-To: <200604252039.k3PKdaZ5020227@elgar.sibelius.xs4all.nl>

On Tue, Apr 25, 2006 at 10:39:36PM +0200, Mark Kettenis wrote:
> Hi Daniel,
> 
> There a slight problem with insert_single_step_breakpoint() and
> remove_single_step_breakpoints().  On OpenBSD, inserting a breakpoint
> into the kernel-provided signal trampoline, may fail.  Unfortunately,
> the caller of insert_single_step_breakpoint() never notices this, and
> calls remove_single_step_breakpoints() to remove the breakpoints.
> Unfortunately that makes us hit the gdb_assert() in there.
> 
> This patch makes us avoid this while still making an attempt to catch
> misuse of the interface.

Hmm - this is also true on some GNU/Linux targets, although none that
use software single step (yet - though I think I know how to trigger it
on ARM, some kernel fixes would also be needed).

My question is, is there something more useful we could be doing? 
If the single step breakpoint fails, then continuing will make us lose
control.  Maybe it should be an error().

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-04-25 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-25 20:40 Mark Kettenis
2006-04-25 21:02 ` Daniel Jacobowitz [this message]
2006-04-25 21:55   ` Mark Kettenis
2006-04-30  3:20     ` Mark Kettenis
2006-05-01 13:54       ` Daniel Jacobowitz
2006-05-01 16:43         ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060425210200.GA1153@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox