From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25124 invoked by alias); 1 May 2006 13:54:58 -0000 Received: (qmail 25115 invoked by uid 22791); 1 May 2006 13:54:57 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 01 May 2006 13:54:54 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FaYrU-0000RM-Bo; Mon, 01 May 2006 09:54:52 -0400 Date: Mon, 01 May 2006 13:54:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: single-step breakpoints Message-ID: <20060501135452.GA1677@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <200604252039.k3PKdaZ5020227@elgar.sibelius.xs4all.nl> <20060425210200.GA1153@nevyn.them.org> <200604252154.k3PLscQe005675@elgar.sibelius.xs4all.nl> <200604292314.k3TNE3uH012648@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200604292314.k3TNE3uH012648@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00000.txt.bz2 On Sun, Apr 30, 2006 at 01:14:03AM +0200, Mark Kettenis wrote: > Yes, erroring out is defenitely a better approach than warn and have > things run away. Here's a patch and some adjustments to the testsuite > to prevent the tests from going into an infinite loop. > > ok? > > > Index: ChangeLog > from Mark Kettenis > > * breakpoint.c (insert_single_step_breakpoint): Make a failure to > insert a single-step breakpoint an error instead of a warning. > > * breakpoint.c (remove_single_step_breakpoints): Bail out early if > no breakpoints are inserted. Yeah, I think this is OK. Ideally, of course, we wouldn't error here. But I'm not sure what would be more sensible to do. We could quietly finish instead, but that would go more than one instruction - quite bad. -- Daniel Jacobowitz CodeSourcery