Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: msnyder@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH]: Don't use deprecated regcache functions
Date: Thu, 13 Apr 2006 01:09:00 -0000	[thread overview]
Message-ID: <20060412.180948.72680402.davem@davemloft.net> (raw)
In-Reply-To: <443D540D.2050902@redhat.com>

From: Michael Snyder <msnyder@redhat.com>
Date: Wed, 12 Apr 2006 12:25:01 -0700

> David S. Miller wrote:
> > From: Daniel Jacobowitz <drow@false.org>
> > Date: Tue, 11 Apr 2006 09:00:57 -0400
> > 
> > 
> >>On Tue, Apr 11, 2006 at 01:39:09AM -0700, David S. Miller wrote:
> >>
> >>>Otherwise, ok to apply?
> >>
> >>>-      deprecated_read_register_gen (regno, raw);
> >>>+      regcache_raw_collect (current_regcache, regno, raw);
> >>>       thread_db_fetch_registers (-1);
> >>>       regcache_raw_supply (current_regcache, regno, raw);
> >>
> >>I might be mistaken, but what the heck does the call to
> >>thread_db_fetch_registers accomplish?  I think nothing.
> 
> Daniel, David's got the right of it.

Ok to apply? :-)


  reply	other threads:[~2006-04-13  1:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-11  8:39 David S. Miller
2006-04-11 13:01 ` Daniel Jacobowitz
2006-04-11 21:13   ` David S. Miller
2006-04-12 19:25     ` Michael Snyder
2006-04-13  1:09       ` David S. Miller [this message]
2006-04-13  2:41         ` Michael Snyder
2006-04-13  4:05           ` David S. Miller
2006-04-13 18:58             ` Michael Snyder
2006-04-20 17:02     ` Daniel Jacobowitz
2006-05-05 22:43       ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060412.180948.72680402.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox