From: Daniel Jacobowitz <drow@false.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH]: Don't use deprecated regcache functions
Date: Tue, 11 Apr 2006 13:01:00 -0000 [thread overview]
Message-ID: <20060411130057.GA21369@nevyn.them.org> (raw)
In-Reply-To: <20060411.013909.129717839.davem@davemloft.net>
On Tue, Apr 11, 2006 at 01:39:09AM -0700, David S. Miller wrote:
>
> I just noticed the following while investigating a threading
> failure on Linux/Sparc.
>
> Any reason we were still using deprecated_read_register_gen()
> here?
Surely not.
> Otherwise, ok to apply?
> - deprecated_read_register_gen (regno, raw);
> + regcache_raw_collect (current_regcache, regno, raw);
> thread_db_fetch_registers (-1);
> regcache_raw_supply (current_regcache, regno, raw);
I might be mistaken, but what the heck does the call to
thread_db_fetch_registers accomplish? I think nothing.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-04-11 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 8:39 David S. Miller
2006-04-11 13:01 ` Daniel Jacobowitz [this message]
2006-04-11 21:13 ` David S. Miller
2006-04-12 19:25 ` Michael Snyder
2006-04-13 1:09 ` David S. Miller
2006-04-13 2:41 ` Michael Snyder
2006-04-13 4:05 ` David S. Miller
2006-04-13 18:58 ` Michael Snyder
2006-04-20 17:02 ` Daniel Jacobowitz
2006-05-05 22:43 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060411130057.GA21369@nevyn.them.org \
--to=drow@false.org \
--cc=davem@davemloft.net \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox