From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15470 invoked by alias); 11 Apr 2006 13:01:03 -0000 Received: (qmail 15461 invoked by uid 22791); 11 Apr 2006 13:01:02 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 11 Apr 2006 13:01:00 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FTIUL-0005Zc-Qh; Tue, 11 Apr 2006 09:00:57 -0400 Date: Tue, 11 Apr 2006 13:01:00 -0000 From: Daniel Jacobowitz To: "David S. Miller" Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: Don't use deprecated regcache functions Message-ID: <20060411130057.GA21369@nevyn.them.org> Mail-Followup-To: "David S. Miller" , gdb-patches@sources.redhat.com References: <20060411.013909.129717839.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060411.013909.129717839.davem@davemloft.net> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00132.txt.bz2 On Tue, Apr 11, 2006 at 01:39:09AM -0700, David S. Miller wrote: > > I just noticed the following while investigating a threading > failure on Linux/Sparc. > > Any reason we were still using deprecated_read_register_gen() > here? Surely not. > Otherwise, ok to apply? > - deprecated_read_register_gen (regno, raw); > + regcache_raw_collect (current_regcache, regno, raw); > thread_db_fetch_registers (-1); > regcache_raw_supply (current_regcache, regno, raw); I might be mistaken, but what the heck does the call to thread_db_fetch_registers accomplish? I think nothing. -- Daniel Jacobowitz CodeSourcery