From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6202 invoked by alias); 13 Apr 2006 01:09:44 -0000 Received: (qmail 6194 invoked by uid 22791); 13 Apr 2006 01:09:44 -0000 X-Spam-Check-By: sourceware.org Received: from dsl027-180-168.sfo1.dsl.speakeasy.net (HELO sunset.davemloft.net) (216.27.180.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 13 Apr 2006 01:09:42 +0000 Received: from localhost ([127.0.0.1] ident=davem) by sunset.davemloft.net with esmtp (Exim 4.60) (envelope-from ) id 1FTqLE-0001BC-91; Wed, 12 Apr 2006 18:09:48 -0700 Date: Thu, 13 Apr 2006 01:09:00 -0000 Message-Id: <20060412.180948.72680402.davem@davemloft.net> To: msnyder@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: Don't use deprecated regcache functions From: "David S. Miller" In-Reply-To: <443D540D.2050902@redhat.com> References: <20060411130057.GA21369@nevyn.them.org> <20060411.141334.116677120.davem@davemloft.net> <443D540D.2050902@redhat.com> X-Mailer: Mew version 4.2.53 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00158.txt.bz2 From: Michael Snyder Date: Wed, 12 Apr 2006 12:25:01 -0700 > David S. Miller wrote: > > From: Daniel Jacobowitz > > Date: Tue, 11 Apr 2006 09:00:57 -0400 > > > > > >>On Tue, Apr 11, 2006 at 01:39:09AM -0700, David S. Miller wrote: > >> > >>>Otherwise, ok to apply? > >> > >>>- deprecated_read_register_gen (regno, raw); > >>>+ regcache_raw_collect (current_regcache, regno, raw); > >>> thread_db_fetch_registers (-1); > >>> regcache_raw_supply (current_regcache, regno, raw); > >> > >>I might be mistaken, but what the heck does the call to > >>thread_db_fetch_registers accomplish? I think nothing. > > Daniel, David's got the right of it. Ok to apply? :-)