Re: Save the length of inserted breakpoints

[Daniel Jacobowitz <drow@false.org>]

On Sat, Mar 04, 2006 at 04:54:04PM +0200, Eli Zaretskii wrote:
> > Date: Sat, 4 Mar 2006 09:43:30 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > 
> > > > There's a division in GDB between the target, which is a method of
> > > > communication et cetera ("how"), and the architecture, which describes
> > > > "what" is being debugged.
> > > 
> > > Btw, is this division described anywhere?
> > 
> > Yes, extensively, in gdbint.
> 
> I looked there before asking, so please tell what is the section name
> that describes this.  Sorry for being blind.

They have their own chapters: Target Architecture Definition and Target
Vector Definition.  Perhaps the titles could be clarified.

GDB's target architecture defines what sort of machine-language
programs GDB can work with, and how it works with them.

versus

The target vector defines the interface between GDB's abstract handling
of target systems, and the nitty-gritty code that actually exercises
control over a process or a serial port.

> > The CPSR support is turning out to be a remarkable pain for such a
> > simple change.
> 
> That's why I thought we should discuss the design aspects here.

Do you have any suggestions for the design?  Mark suggested a more
symmetric interface, which I agreed to implement.  You suggested not
modifying the interface and instead having targets keep track.  I've
tried to explain why I don't think that's a good idea, but if you
aren't convinced, I'll do it that way instead.

Heh... another way I could make the interface more symmetric would be
to bump up the size of the shadow contents vector, and have targets
which care about the size store the length in there when inserting
the breakpoint.

-- 
Daniel Jacobowitz
CodeSourcery