Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: gdb-patches@sources.redhat.com, cagney@redhat.com
Subject: Re: cope with varying prelink base addresses
Date: Mon, 20 Feb 2006 17:43:00 -0000	[thread overview]
Message-ID: <20060220174327.GF19356@nevyn.them.org> (raw)
In-Reply-To: <ormzh2zawm.fsf@livre.oliva.athome.lsd.ic.unicamp.br>

On Wed, Feb 08, 2006 at 03:18:01AM -0200, Alexandre Oliva wrote:
> I'd appreciate if whoever reviews this would pay particular attention
> to the gdb testcase; it's the first time I write one, and I could use
> some guidance to make sure I'm not making undeserved assumptions.
> It's bad enough that I have to use compile- and run-time flags that
> will likely only work with GCC and GNU ld, and that the test requires
> the prelink program to be in the PATH; I hope I'm coping well with
> cases in which the flags are not accepted or prelink is not in place.

The testcase behaves on Solaris, where there's no prelink binary.  I'm
a little worried about it being noisy where -shared doesn't work,
and with various non-GCC tools.  Maybe move the gcc_compiled check
further up?

Oh, and please add copyright notices to the testsuite files; they're
pretty trivial, but we're trying to be consistent about that.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2006-02-20 17:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-08  5:35 Alexandre Oliva
2006-02-08  6:25 ` Eli Zaretskii
2006-02-10  0:15   ` Alexandre Oliva
2006-02-08 21:40 ` Mark Kettenis
2006-02-10  0:09   ` Alexandre Oliva
2006-02-10  1:42     ` Daniel Jacobowitz
2006-02-13 19:03       ` Alexandre Oliva
2006-02-14  0:56         ` Kevin Buettner
2006-02-14  2:08           ` Daniel Jacobowitz
2006-02-14 18:40             ` Alexandre Oliva
2006-02-14 18:53               ` Mark Kettenis
2006-02-20 18:16                 ` Alexandre Oliva
2006-02-20 21:49                   ` Mark Kettenis
2006-02-20 17:37               ` Daniel Jacobowitz
2006-02-20 17:43 ` Daniel Jacobowitz [this message]
2006-02-23 20:22   ` Alexandre Oliva
2006-02-23 20:53     ` Daniel Jacobowitz
2006-02-24  7:42       ` Alexandre Oliva
2006-02-28  1:50         ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060220174327.GF19356@nevyn.them.org \
    --to=drow@false.org \
    --cc=aoliva@redhat.com \
    --cc=cagney@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox