From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7212 invoked by alias); 20 Feb 2006 17:43:32 -0000 Received: (qmail 7204 invoked by uid 22791); 20 Feb 2006 17:43:31 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 20 Feb 2006 17:43:30 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FBF4J-0005JA-V0; Mon, 20 Feb 2006 12:43:28 -0500 Date: Mon, 20 Feb 2006 17:43:00 -0000 From: Daniel Jacobowitz To: Alexandre Oliva Cc: gdb-patches@sources.redhat.com, cagney@redhat.com Subject: Re: cope with varying prelink base addresses Message-ID: <20060220174327.GF19356@nevyn.them.org> Mail-Followup-To: Alexandre Oliva , gdb-patches@sources.redhat.com, cagney@redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00373.txt.bz2 On Wed, Feb 08, 2006 at 03:18:01AM -0200, Alexandre Oliva wrote: > I'd appreciate if whoever reviews this would pay particular attention > to the gdb testcase; it's the first time I write one, and I could use > some guidance to make sure I'm not making undeserved assumptions. > It's bad enough that I have to use compile- and run-time flags that > will likely only work with GCC and GNU ld, and that the test requires > the prelink program to be in the PATH; I hope I'm coping well with > cases in which the flags are not accepted or prelink is not in place. The testcase behaves on Solaris, where there's no prelink binary. I'm a little worried about it being noisy where -shared doesn't work, and with various non-GCC tools. Maybe move the gcc_compiled check further up? Oh, and please add copyright notices to the testsuite files; they're pretty trivial, but we're trying to be consistent about that. -- Daniel Jacobowitz CodeSourcery