Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Fred Fish <fnf@specifix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix problem with scope.exp test, skipping past init0 call
Date: Mon, 13 Feb 2006 15:39:00 -0000	[thread overview]
Message-ID: <20060213153903.GA26349@nevyn.them.org> (raw)
In-Reply-To: <200602121510.01657.fnf@specifix.com>

While Jim's already approved the patch, and it's fine, some other
notes...

On Sun, Feb 12, 2006 at 03:10:01PM -0500, Fred Fish wrote:
> I noticed the following failures while running the gdb testsuite and
> decided to investigate:
> 
>   Running /src/latest/trunk/src/gdb/gdb/testsuite/gdb.base/scope.exp ...
>   FAIL: gdb.base/scope.exp: next over init0() in main
>   FAIL: gdb.base/scope.exp: print filelocal_bss
>   FAIL: gdb.base/scope.exp: print 'scope0.c'::filelocal_bss in test_at_main
>   FAIL: gdb.base/scope.exp: print 'scope1.c'::filelocal_bss

What platform and compiler version is this?  It doesn't fail for me.

> The problem was triggered by the fact that the breakpoint on main was
> being set at the opening brace and then the first next only took us to
> the init0 call.  This might be a bug in it's own right, but scope.exp
> is supposed to handle this as a side effect of an attempt to skip
> __main:
> 
>     # skip past init.  There may be a call to __main at the start of
>     # main, so the first next may only get us to the init0 call.
>     if [gdb_test "next" "$decimal.*foo \\(\\);" "next over init0() in main"  "$decimal.*init0 \\(\\);" "next"] {
>       gdb_suppress_tests ;
>     }

Well, that's supposed to skip a call to __main(), which GCC generates
on very few platforms... stopping at the opening brace is definitely
a bug in its own right, in the debug info or in the prologue skipper.


-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2006-02-13 15:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-12 20:10 Fred Fish
2006-02-13  6:16 ` Jim Blandy
2006-02-13 15:39 ` Daniel Jacobowitz [this message]
2006-02-13 15:47   ` Fred Fish
2006-02-13 15:53     ` Daniel Jacobowitz
2006-02-13 16:05     ` Mark Kettenis
2006-02-13 16:08       ` Daniel Jacobowitz
2006-02-13 16:19       ` Fred Fish
2006-02-13 16:49         ` Mark Kettenis
2006-02-13 17:47           ` Jim Blandy
2006-02-13 17:54             ` Jim Blandy
2006-02-13 17:57               ` Jim Blandy
2006-02-13 18:08                 ` Mark Kettenis
2006-03-02  0:01             ` Michael Snyder
2006-03-02  6:09               ` Jim Blandy
2006-02-13 18:39           ` Fred Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060213153903.GA26349@nevyn.them.org \
    --to=drow@false.org \
    --cc=fnf@specifix.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox