From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18563 invoked by alias); 13 Feb 2006 15:39:12 -0000 Received: (qmail 18552 invoked by uid 22791); 13 Feb 2006 15:39:11 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 13 Feb 2006 15:39:07 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F8fn6-0006t2-86; Mon, 13 Feb 2006 10:39:04 -0500 Date: Mon, 13 Feb 2006 15:39:00 -0000 From: Daniel Jacobowitz To: Fred Fish Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix problem with scope.exp test, skipping past init0 call Message-ID: <20060213153903.GA26349@nevyn.them.org> Mail-Followup-To: Fred Fish , gdb-patches@sourceware.org References: <200602121510.01657.fnf@specifix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200602121510.01657.fnf@specifix.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00275.txt.bz2 While Jim's already approved the patch, and it's fine, some other notes... On Sun, Feb 12, 2006 at 03:10:01PM -0500, Fred Fish wrote: > I noticed the following failures while running the gdb testsuite and > decided to investigate: > > Running /src/latest/trunk/src/gdb/gdb/testsuite/gdb.base/scope.exp ... > FAIL: gdb.base/scope.exp: next over init0() in main > FAIL: gdb.base/scope.exp: print filelocal_bss > FAIL: gdb.base/scope.exp: print 'scope0.c'::filelocal_bss in test_at_main > FAIL: gdb.base/scope.exp: print 'scope1.c'::filelocal_bss What platform and compiler version is this? It doesn't fail for me. > The problem was triggered by the fact that the breakpoint on main was > being set at the opening brace and then the first next only took us to > the init0 call. This might be a bug in it's own right, but scope.exp > is supposed to handle this as a side effect of an attempt to skip > __main: > > # skip past init. There may be a call to __main at the start of > # main, so the first next may only get us to the init0 call. > if [gdb_test "next" "$decimal.*foo \\(\\);" "next over init0() in main" "$decimal.*init0 \\(\\);" "next"] { > gdb_suppress_tests ; > } Well, that's supposed to skip a call to __main(), which GCC generates on very few platforms... stopping at the opening brace is definitely a bug in its own right, in the debug info or in the prologue skipper. -- Daniel Jacobowitz CodeSourcery