Re: [RFA/rs6000-aix] software_single_step gdbarch method no longer set

Re: [RFA/rs6000-aix] software_single_step gdbarch method no longer set

[Joel Brobecker]

Hey Daniel,

I am just realizing that I never got around to answering you.

> I have not looked at the patch much (won't this year).  However, if
> you're feeling especially motivated, we could sidestep this issue...
> there's a related cleanup I've been meaning to do for a long while.
> 
> The software single step method in the gdbarch is always used if it is
> set.  But, that doesn't make a lot of sense.  The gdbarch method should
> mean "software single step is supported"; the predicate "software
> single step is required" should live in the target vector instead! 
> It's a property of the target.  e.g. MIPS GNU/Linux doesn't implement
> PTRACE_SINGLESTEP, but if you're connected to a kernel debugging
> session using a hardware ICE, then maybe you've really got hardware
> single step.

Makes sense, but ...

> It's unfortunately a little trickier than that since remote targets
> don't currently report whether using software singlestep is OK :-(
> So setting the default behavior may not be simple.  I know gdbserver
> needs some adjustment here.

I don't have that much time in the forseeable future to work on this,
unfortunately. I would also like to work on some other cleanup
activities, including the procfs stuff (which I promised to Mark and
yet haven't had time to look at).

So I'd rather see if my proposal can go in for now.

Thanks,
-- 
Joel

Re: [RFA/rs6000-aix] software_single_step gdbarch method no longer set

[Kevin Buettner]

On Tue, 7 Feb 2006 12:03:51 -0800
Joel Brobecker <brobecker@adacore.com> wrote:

> Makes sense, but ...
> 
> > It's unfortunately a little trickier than that since remote targets
> > don't currently report whether using software singlestep is OK :-(
> > So setting the default behavior may not be simple.  I know gdbserver
> > needs some adjustment here.
> 
> I don't have that much time in the forseeable future to work on this,
> unfortunately. I would also like to work on some other cleanup
> activities, including the procfs stuff (which I promised to Mark and
> yet haven't had time to look at).
> 
> So I'd rather see if my proposal can go in for now.

I've just looked over your patch.  It looks reasonable to me and I think
it should go in.

Kevin

Re: [RFA/rs6000-aix] software_single_step gdbarch method no longer set

[Daniel Jacobowitz]

On Thu, Feb 09, 2006 at 10:55:57AM -0700, Kevin Buettner wrote:
> On Tue, 7 Feb 2006 12:03:51 -0800
> Joel Brobecker <brobecker@adacore.com> wrote:
> 
> > Makes sense, but ...
> > 
> > > It's unfortunately a little trickier than that since remote targets
> > > don't currently report whether using software singlestep is OK :-(
> > > So setting the default behavior may not be simple.  I know gdbserver
> > > needs some adjustment here.
> > 
> > I don't have that much time in the forseeable future to work on this,
> > unfortunately. I would also like to work on some other cleanup
> > activities, including the procfs stuff (which I promised to Mark and
> > yet haven't had time to look at).
> > 
> > So I'd rather see if my proposal can go in for now.
> 
> I've just looked over your patch.  It looks reasonable to me and I think
> it should go in.

I totally agree; apologies if my suggestion came across as an
objection.  I just looked at the patch for the first time and
it looks totally fine.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA/rs6000-aix] software_single_step gdbarch method no longer set

[Joel Brobecker]

> 2005-12-31  Joel Brobecker  <brobecker@adacore.com>
> 
>         * defs.h (gdb_osabi): New enum value GDB_OSABI_AIX.
>         * osabi.c (gdb_osabi_name): Add name of new value GDB_OSABI_AIX.
>         * rs6000-tdep.h: New file.
>         * rs6000-tdep.c: Include "rs6000-tdep.h".
>         (rs6000_gdbarch_init): Remove enabling of software single step.
>         Will be done in the AIX-specific initialization routine.
>         * rs6000-aix-tdep.c: New file.
>         * config/powerpc/aix.mt (TDEPFILES): Add rs6000-aix-tdep.o.
>         * Makefile.in (rs6000_tdep_h): New variable.
>         (rs6000-tdep.o): Update dependencies.
>         (rs6000-aix-tdep.o): New rule.

Thanks to Kevin and Daniel for the review.
I just checked the patch in.

-- 
Joel

Re: [RFA/rs6000-aix] software_single_step gdbarch method no longer set

[Jim Blandy]

In rs6000_aix_osabi_sniffer, is it really necessary to check whether
bfd_get_flavour (abfd) == bfd_target_xcoff_flavour?  You've already
restricted the sniffer to bfd_target_xcoff_flavour when you called
gdbarch_register_osabi_sniffer, if I'm reading gdbarch_lookup_osabi
correctly.

Re: [RFA/rs6000-aix] software_single_step gdbarch method no longer set

[Joel Brobecker]

> In rs6000_aix_osabi_sniffer, is it really necessary to check whether
> bfd_get_flavour (abfd) == bfd_target_xcoff_flavour?  You've already
> restricted the sniffer to bfd_target_xcoff_flavour when you called
> gdbarch_register_osabi_sniffer, if I'm reading gdbarch_lookup_osabi
> correctly.

You are very likely right. This is a good catch, I will test the
obvious patch asap.

Thanks!
-- 
Joel