From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2068 invoked by alias); 12 Feb 2006 07:46:47 -0000 Received: (qmail 2060 invoked by uid 22791); 12 Feb 2006 07:46:46 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.198) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 12 Feb 2006 07:46:45 +0000 Received: by zproxy.gmail.com with SMTP id 4so778220nzn for ; Sat, 11 Feb 2006 23:46:44 -0800 (PST) Received: by 10.36.158.18 with SMTP id g18mr1539318nze; Sat, 11 Feb 2006 23:46:43 -0800 (PST) Received: by 10.37.2.63 with HTTP; Sat, 11 Feb 2006 23:46:43 -0800 (PST) Message-ID: <8f2776cb0602112346m53521756t4c87aedd15aaabd5@mail.gmail.com> Date: Sun, 12 Feb 2006 07:46:00 -0000 From: Jim Blandy To: Joel Brobecker Subject: Re: [RFA/rs6000-aix] software_single_step gdbarch method no longer set Cc: gdb-patches@sources.redhat.com In-Reply-To: <20051231054133.GL4734@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20051231054133.GL4734@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00268.txt.bz2 In rs6000_aix_osabi_sniffer, is it really necessary to check whether bfd_get_flavour (abfd) =3D=3D bfd_target_xcoff_flavour? You've already restricted the sniffer to bfd_target_xcoff_flavour when you called gdbarch_register_osabi_sniffer, if I'm reading gdbarch_lookup_osabi correctly.