[ob] Rename NO_ERROR

[ob] Rename NO_ERROR

[Daniel Jacobowitz]

The Windows (at least mingw32's version) headers apparently define NO_ERROR.
The least of several cretinous things I've learned about Windows programming
in the last week.

Committed as obvious.

-- 
Daniel Jacobowitz
CodeSourcery

2006-02-03  Daniel Jacobowitz  <dan@codesourcery.com>

	* exceptions.h (enum errors): Rename NO_ERROR to GDB_NO_ERROR.
	* exceptions.c (exception_none, exceptions_state_mc_init)
	(throw_vfatal): Use GDB_NO_ERROR.

Index: src/gdb/exceptions.c
===================================================================
--- src.orig/gdb/exceptions.c	2006-02-03 15:13:03.000000000 -0500
+++ src/gdb/exceptions.c	2006-02-03 15:13:18.000000000 -0500
@@ -1,8 +1,8 @@
 /* Exception (throw catch) mechanism, for GDB, the GNU debugger.
 
    Copyright (C) 1986, 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995,
-   1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005 Free
-   Software Foundation, Inc.
+   1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006
+   Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -32,7 +32,7 @@
 #include "gdb_string.h"
 #include "serial.h"
 
-const struct gdb_exception exception_none = { 0, NO_ERROR, NULL };
+const struct gdb_exception exception_none = { 0, GDB_NO_ERROR, NULL };
 
 /* Possible catcher states.  */
 enum catcher_state {
@@ -79,7 +79,7 @@ exceptions_state_mc_init (struct ui_out 
 
   /* Start with no exception, save it's address.  */
   exception->reason = 0;
-  exception->error = NO_ERROR;
+  exception->error = GDB_NO_ERROR;
   exception->message = NULL;
   new_catcher->exception = exception;
 
@@ -404,7 +404,7 @@ throw_verror (enum errors error, const c
 NORETURN void
 throw_vfatal (const char *fmt, va_list ap)
 {
-  throw_it (RETURN_QUIT, NO_ERROR, fmt, ap);
+  throw_it (RETURN_QUIT, GDB_NO_ERROR, fmt, ap);
 }
 
 NORETURN void
Index: src/gdb/exceptions.h
===================================================================
--- src.orig/gdb/exceptions.h	2006-02-03 15:13:03.000000000 -0500
+++ src/gdb/exceptions.h	2006-02-03 15:13:24.000000000 -0500
@@ -1,8 +1,8 @@
 /* Exception (throw catch) mechanism, for GDB, the GNU debugger.
 
    Copyright (C) 1986, 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995,
-   1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005 Free
-   Software Foundation, Inc.
+   1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006
+   Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -50,7 +50,7 @@ typedef int return_mask;
 /* Describe all exceptions.  */
 
 enum errors {
-  NO_ERROR,
+  GDB_NO_ERROR,
   /* Any generic error, the corresponding text is in
      exception.message.  */
   GENERIC_ERROR,

Re: [ob] Rename NO_ERROR

[Eli Zaretskii]

> Date: Fri, 3 Feb 2006 16:51:46 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> The Windows (at least mingw32's version) headers apparently define NO_ERROR.
> The least of several cretinous things I've learned about Windows programming
> in the last week.

Out of curiosity, what were the other cretinous things?  (Mail me
privately if you think the answer will not be interesting to others.)

Re: [ob] Rename NO_ERROR

[Daniel Jacobowitz]

On Sat, Feb 04, 2006 at 02:00:05PM +0200, Eli Zaretskii wrote:
> > Date: Fri, 3 Feb 2006 16:51:46 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > 
> > The Windows (at least mingw32's version) headers apparently define NO_ERROR.
> > The least of several cretinous things I've learned about Windows programming
> > in the last week.
> 
> Out of curiosity, what were the other cretinous things?  (Mail me
> privately if you think the answer will not be interesting to others.)

I'm just referring to the other two patches I posted Friday night (and
the responses they've received, not entirely unexpected).  The
explanation I just sent about waiting on handles, in particular,
and the decision to put useful error messages well out of range of
strerror.

-- 
Daniel Jacobowitz
CodeSourcery