From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: RFC: Fix various problems with "printf" and warnings
Date: Thu, 02 Feb 2006 02:26:00 -0000 [thread overview]
Message-ID: <20060202022652.GD19694@nevyn.them.org> (raw)
In-Reply-To: <20060122003117.GC8088@nevyn.them.org>
On Sat, Jan 21, 2006 at 07:31:17PM -0500, Daniel Jacobowitz wrote:
> 2006-01-21 Daniel Jacobowitz <dan@codesourcery.com>
>
> * printcmd.c (printf_command): Make format string checking
> stricter. Add separate cases for long_arg, ptr_arg, and
> long_double_arg.
> * utils.c (xstrvprintf): Improve the error message issued
> for a bad format string.
> * Makefile.in (GDB_WARN_CFLAGS_NO_FORMAT, INTERNAL_CFLAGS_BASE):
> New variables.
> (gnu-v3-abi.o, monitor.o, procfs.o, linux-thread-db.o): Remove
> $(NO_WERROR_CFLAGS).
> (printcmd.o): Likewise. Use $(GDB_WARN_CFLAGS_NO_FORMAT) and
> enable -Werror.
Thanks to everyone who commented; I've now checked this in. A lot of
other targets aren't, but x86_64-linux native is now warning-free.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2006-02-02 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 0:31 Daniel Jacobowitz
2006-01-22 1:22 ` Andreas Schwab
2006-01-22 2:36 ` Daniel Jacobowitz
2006-01-22 4:28 ` Eli Zaretskii
2006-01-22 4:56 ` Daniel Jacobowitz
2006-01-22 19:10 ` Eli Zaretskii
2006-01-22 6:38 ` Jim Blandy
2006-01-22 16:36 ` Daniel Jacobowitz
2006-02-02 2:26 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060202022652.GD19694@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox