From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23727 invoked by alias); 2 Feb 2006 02:26:58 -0000 Received: (qmail 23716 invoked by uid 22791); 2 Feb 2006 02:26:57 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 02 Feb 2006 02:26:55 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F4UBQ-0005O6-A4 for gdb-patches@sourceware.org; Wed, 01 Feb 2006 21:26:52 -0500 Date: Thu, 02 Feb 2006 02:26:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: RFC: Fix various problems with "printf" and warnings Message-ID: <20060202022652.GD19694@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060122003117.GC8088@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060122003117.GC8088@nevyn.them.org> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00021.txt.bz2 On Sat, Jan 21, 2006 at 07:31:17PM -0500, Daniel Jacobowitz wrote: > 2006-01-21 Daniel Jacobowitz > > * printcmd.c (printf_command): Make format string checking > stricter. Add separate cases for long_arg, ptr_arg, and > long_double_arg. > * utils.c (xstrvprintf): Improve the error message issued > for a bad format string. > * Makefile.in (GDB_WARN_CFLAGS_NO_FORMAT, INTERNAL_CFLAGS_BASE): > New variables. > (gnu-v3-abi.o, monitor.o, procfs.o, linux-thread-db.o): Remove > $(NO_WERROR_CFLAGS). > (printcmd.o): Likewise. Use $(GDB_WARN_CFLAGS_NO_FORMAT) and > enable -Werror. Thanks to everyone who commented; I've now checked this in. A lot of other targets aren't, but x86_64-linux native is now warning-free. -- Daniel Jacobowitz CodeSourcery