Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: RFC: Fix various problems with "printf" and warnings
Date: Sun, 22 Jan 2006 02:36:00 -0000	[thread overview]
Message-ID: <20060122023602.GA12414@nevyn.them.org> (raw)
In-Reply-To: <je4q3xkqf2.fsf@sykes.suse.de>

On Sun, Jan 22, 2006 at 02:22:09AM +0100, Andreas Schwab wrote:
> Daniel Jacobowitz <drow@false.org> writes:
> 
> > +	    case 'o':
> > +	    case 'x':
> > +	    case 'X':
> > +	      if (seen_space || seen_plus)
> > +		bad = 1;
> 
> I don't think this should be rejected.  I've got only the C99 spec, but I
> don't think that C89 is different here in that space and plus are ignored
> for unsigned and non-numeric conversions.

That's what I figured too, but on the other hand, GCC warns about them:

drow@nevyn:~% gcc -Wformat -o a a.c
a.c: In function 'main':
a.c:7: warning: ' ' flag used with '%o' printf format

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-01-22  2:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-22  0:31 Daniel Jacobowitz
2006-01-22  1:22 ` Andreas Schwab
2006-01-22  2:36   ` Daniel Jacobowitz [this message]
2006-01-22  4:28 ` Eli Zaretskii
2006-01-22  4:56   ` Daniel Jacobowitz
2006-01-22 19:10     ` Eli Zaretskii
2006-01-22  6:38 ` Jim Blandy
2006-01-22 16:36   ` Daniel Jacobowitz
2006-02-02  2:26 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060122023602.GA12414@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox