From: Daniel Jacobowitz <drow@false.org>
To: Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
Cc: Jim Blandy <jimb@red-bean.com>, gdb-patches@sources.redhat.com
Subject: Re: Fix for PR 1971 .
Date: Wed, 04 Jan 2006 13:56:00 -0000 [thread overview]
Message-ID: <20060104135626.GA2159@nevyn.them.org> (raw)
In-Reply-To: <1136350956.8215.14.camel@localhost.localdomain>
On Wed, Jan 04, 2006 at 10:32:36AM +0530, Ramana Radhakrishnan wrote:
> 2006-01-04 Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
>
> PR 1971
> * infrun.c (insert_step_resume_breakpoint_at_caller):New
> function.
> (handle_inferior_event):Use above.
Looks reasonable to me, but you need to correct some formatting
problems first. Thanks for fixing this.
The ChangeLog entry should be:
2006-01-04 Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
PR 1971
* infrun.c (insert_step_resume_breakpoint_at_caller): New function.
(handle_inferior_event): Use above.
Leading tabs, and a space after the colon.
> @@ -2390,7 +2391,8 @@
> /* We're doing a "next", set a breakpoint at callee's return
> address (the address at which the caller will
> resume). */
> - insert_step_resume_breakpoint_at_frame (get_prev_frame (get_current_frame ()));
> +
> + insert_step_resume_breakpoint_at_caller ( get_current_frame ());
No space after the open parenthesis please (here and several times
below).
> + if (get_prev_frame (return_frame))
> + {
> + insert_step_resume_breakpoint_at_frame (get_prev_frame (return_frame));
> + }
No need for the extra braces here.
> + else
> + {
> + struct symtab_and_line sr_sal;
> + init_sal (&sr_sal); /* initialize to zeros */
/* Initialize to zeros. */
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2006-01-04 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-03 18:41 Ramana Radhakrishnan
2006-01-03 23:34 ` Jim Blandy
2006-01-03 23:43 ` Jim Blandy
2006-01-04 5:07 ` Ramana Radhakrishnan
2006-01-04 5:55 ` Jim Blandy
2006-01-04 6:52 ` Ramana Radhakrishnan
2006-01-04 7:57 ` Jim Blandy
2006-01-04 8:27 ` Ramana Radhakrishnan
2006-01-04 13:56 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060104135626.GA2159@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@red-bean.com \
--cc=ramana.radhakrishnan@codito.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox