From: Jim Blandy <jimb@red-bean.com>
To: ramana.radhakrishnan@codito.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fix for PR 1971 .
Date: Wed, 04 Jan 2006 07:57:00 -0000 [thread overview]
Message-ID: <8f2776cb0601032357q32754aaxef1ac495584c9ca4@mail.gmail.com> (raw)
In-Reply-To: <1136356104.17597.47.camel@localhost.localdomain>
On 1/3/06, Ramana Radhakrishnan <ramana.radhakrishnan@codito.com> wrote:
> I am not sure about removing the get_prev_frame. We need it for the
> correct frame id . In case you were stepping over a recursive call and
> deep inside after main had executed you would need the correct frame id
> of the return frame and in the other case a null_frame_id.
Okay, I see.
Hmm. If I'm reading breakpoint.c right, null_frame_id acts as a
wildcard, saying, treat the breakpoint as applying to any frame. So
we're assuming that, whoever the caller of the "oldest" frame is, it's
not going to be called recursively (or else the step-resume breakpoint
would trigger in one of the inner frames). I don't know if that case
is worth worrying about.
It looks okay to me, then. Let's let it sit for a few days; if nobody
has futher comments, go ahead and commit.
next prev parent reply other threads:[~2006-01-04 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-03 18:41 Ramana Radhakrishnan
2006-01-03 23:34 ` Jim Blandy
2006-01-03 23:43 ` Jim Blandy
2006-01-04 5:07 ` Ramana Radhakrishnan
2006-01-04 5:55 ` Jim Blandy
2006-01-04 6:52 ` Ramana Radhakrishnan
2006-01-04 7:57 ` Jim Blandy [this message]
2006-01-04 8:27 ` Ramana Radhakrishnan
2006-01-04 13:56 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0601032357q32754aaxef1ac495584c9ca4@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=gdb-patches@sources.redhat.com \
--cc=ramana.radhakrishnan@codito.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox