From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8458 invoked by alias); 4 Jan 2006 13:56:45 -0000 Received: (qmail 8445 invoked by uid 22791); 4 Jan 2006 13:56:44 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 04 Jan 2006 13:56:43 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Eu97r-0000cB-4m; Wed, 04 Jan 2006 08:56:27 -0500 Date: Wed, 04 Jan 2006 13:56:00 -0000 From: Daniel Jacobowitz To: Ramana Radhakrishnan Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: Fix for PR 1971 . Message-ID: <20060104135626.GA2159@nevyn.them.org> Mail-Followup-To: Ramana Radhakrishnan , Jim Blandy , gdb-patches@sources.redhat.com References: <1136312069.8808.24.camel@localhost.localdomain> <8f2776cb0601031534p23c54aadkdccb840296911560@mail.gmail.com> <8f2776cb0601031543g4fc5a45bj9cf367c82d6793b0@mail.gmail.com> <1136350956.8215.14.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1136350956.8215.14.camel@localhost.localdomain> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00039.txt.bz2 On Wed, Jan 04, 2006 at 10:32:36AM +0530, Ramana Radhakrishnan wrote: > 2006-01-04 Ramana Radhakrishnan > > PR 1971 > * infrun.c (insert_step_resume_breakpoint_at_caller):New > function. > (handle_inferior_event):Use above. Looks reasonable to me, but you need to correct some formatting problems first. Thanks for fixing this. The ChangeLog entry should be: 2006-01-04 Ramana Radhakrishnan PR 1971 * infrun.c (insert_step_resume_breakpoint_at_caller): New function. (handle_inferior_event): Use above. Leading tabs, and a space after the colon. > @@ -2390,7 +2391,8 @@ > /* We're doing a "next", set a breakpoint at callee's return > address (the address at which the caller will > resume). */ > - insert_step_resume_breakpoint_at_frame (get_prev_frame (get_current_frame ())); > + > + insert_step_resume_breakpoint_at_caller ( get_current_frame ()); No space after the open parenthesis please (here and several times below). > + if (get_prev_frame (return_frame)) > + { > + insert_step_resume_breakpoint_at_frame (get_prev_frame (return_frame)); > + } No need for the extra braces here. > + else > + { > + struct symtab_and_line sr_sal; > + init_sal (&sr_sal); /* initialize to zeros */ /* Initialize to zeros. */ -- Daniel Jacobowitz CodeSourcery