* [commit] ia64-tdep.c: update an argument type in floatformat_valid()
@ 2005-11-08 17:17 Kevin Buettner
2005-11-08 17:28 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2005-11-08 17:17 UTC (permalink / raw)
To: gdb-patches
I've just committed the change below. With this change in place, the
ia64-linux-gnu target builds using -Werror.
* ia64-tdep.c (floatformat_valid): Change type of `from' from
`const char *' to `const void *'.
Index: ia64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ia64-tdep.c,v
retrieving revision 1.135
diff -u -p -r1.135 ia64-tdep.c
--- ia64-tdep.c 10 Sep 2005 18:11:02 -0000 1.135
+++ ia64-tdep.c 8 Nov 2005 01:40:24 -0000
@@ -324,7 +324,7 @@ ia64_dwarf_reg_to_regnum (int reg)
}
static int
-floatformat_valid (const struct floatformat *fmt, const char *from)
+floatformat_valid (const struct floatformat *fmt, const void *from)
{
return 1;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [commit] ia64-tdep.c: update an argument type in floatformat_valid()
2005-11-08 17:17 [commit] ia64-tdep.c: update an argument type in floatformat_valid() Kevin Buettner
@ 2005-11-08 17:28 ` Mark Kettenis
2005-11-09 6:29 ` Kevin Buettner
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2005-11-08 17:28 UTC (permalink / raw)
To: kevinb; +Cc: gdb-patches
> Date: Mon, 7 Nov 2005 18:46:10 -0700
> From: Kevin Buettner <kevinb@redhat.com>
>
> I've just committed the change below. With this change in place, the
> ia64-linux-gnu target builds using -Werror.
>
> * ia64-tdep.c (floatformat_valid): Change type of `from' from
> `const char *' to `const void *'.
Hmm, why doesn't ia64-tdep.c use one of the ia64-specific types from
floatformat.[ch]?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [commit] ia64-tdep.c: update an argument type in floatformat_valid()
2005-11-08 17:28 ` Mark Kettenis
@ 2005-11-09 6:29 ` Kevin Buettner
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Buettner @ 2005-11-09 6:29 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches
On Tue, 8 Nov 2005 08:16:19 +0100 (CET)
Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> > Date: Mon, 7 Nov 2005 18:46:10 -0700
> > From: Kevin Buettner <kevinb@redhat.com>
> >
> > I've just committed the change below. With this change in place, the
> > ia64-linux-gnu target builds using -Werror.
> >
> > * ia64-tdep.c (floatformat_valid): Change type of `from' from
> > `const char *' to `const void *'.
>
> Hmm, why doesn't ia64-tdep.c use one of the ia64-specific types from
> floatformat.[ch]?
GDB's ia64-tdep.c defines a floatformat type that is not yet in libiberty.
It probably ought to be moved over to libiberty...
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-08 17:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-08 17:17 [commit] ia64-tdep.c: update an argument type in floatformat_valid() Kevin Buettner
2005-11-08 17:28 ` Mark Kettenis
2005-11-09 6:29 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox