From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24497 invoked by alias); 8 Nov 2005 17:25:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24467 invoked by uid 22791); 8 Nov 2005 17:25:31 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 08 Nov 2005 17:25:31 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id jA8HPOJl021643 for ; Tue, 8 Nov 2005 12:25:30 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id jA8HPOV08627; Tue, 8 Nov 2005 12:25:24 -0500 Received: from localhost.localdomain (vpn50-70.rdu.redhat.com [172.16.50.70]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id jA8HPOWs027631; Tue, 8 Nov 2005 12:25:24 -0500 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id jA8HPItN008395; Tue, 8 Nov 2005 10:25:19 -0700 Date: Wed, 09 Nov 2005 06:29:00 -0000 From: Kevin Buettner To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] ia64-tdep.c: update an argument type in floatformat_valid() Message-ID: <20051108102518.2e6054a2@ironwood.lan> In-Reply-To: <200511080716.jA87GJO8015781@elgar.sibelius.xs4all.nl> References: <20051107184610.7472b928@ironwood.lan> <200511080716.jA87GJO8015781@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2005-11/txt/msg00099.txt.bz2 On Tue, 8 Nov 2005 08:16:19 +0100 (CET) Mark Kettenis wrote: > > Date: Mon, 7 Nov 2005 18:46:10 -0700 > > From: Kevin Buettner > > > > I've just committed the change below. With this change in place, the > > ia64-linux-gnu target builds using -Werror. > > > > * ia64-tdep.c (floatformat_valid): Change type of `from' from > > `const char *' to `const void *'. > > Hmm, why doesn't ia64-tdep.c use one of the ia64-specific types from > floatformat.[ch]? GDB's ia64-tdep.c defines a floatformat type that is not yet in libiberty. It probably ought to be moved over to libiberty... Kevin