* [COMMIT] Fix warning in event-top.c
@ 2005-11-02 6:06 Joel Brobecker
2005-11-02 11:03 ` Andrew STUBBS
0 siblings, 1 reply; 2+ messages in thread
From: Joel Brobecker @ 2005-11-02 6:06 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
Currently running gdb_mbuild pretty much for the first time, and
disovering lots of builds failures, mostly because of -Werror. Here
is a fix the one warning in one of the core files. I think the other
ones are in target dependent files.
2005-11-02 Joel Brobecker <brobecker@adacore.com>
* event-top.c (gdb_setup_readline): Add missing type in extern
declaration.
Fixes the following compiler warning:
event-top.c: In function `gdb_setup_readline':
event-top.c:1113: warning: type defaults to `int' in declaration of `batch_silent'
Here is where the variable is defined:
main.c:int batch_silent = 0;
Tested on x86-linux, no regression in the testsuite. I'm committing
this under the obvious fix rule. I think it's pretty obvious.
--
Joel
[-- Attachment #2: event-top.c.diff --]
[-- Type: text/plain, Size: 590 bytes --]
Index: event-top.c
===================================================================
RCS file: /cvs/src/src/gdb/event-top.c,v
retrieving revision 1.41
diff -u -p -r1.41 event-top.c
--- event-top.c 1 Nov 2005 11:09:18 -0000 1.41
+++ event-top.c 2 Nov 2005 05:43:44 -0000
@@ -1110,7 +1110,7 @@ gdb_setup_readline (void)
that the sync setup is ALL done in gdb_init, and we would only
mess it up here. The sync stuff should really go away over
time. */
- extern batch_silent;
+ extern int batch_silent;
if (!batch_silent)
gdb_stdout = stdio_fileopen (stdout);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [COMMIT] Fix warning in event-top.c
2005-11-02 6:06 [COMMIT] Fix warning in event-top.c Joel Brobecker
@ 2005-11-02 11:03 ` Andrew STUBBS
0 siblings, 0 replies; 2+ messages in thread
From: Andrew STUBBS @ 2005-11-02 11:03 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
Joel Brobecker wrote:
> Fixes the following compiler warning:
>
> event-top.c: In function `gdb_setup_readline':
> event-top.c:1113: warning: type defaults to `int' in declaration of `batch_silent'
Apologies, I should have spotted that one.
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-02 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-02 6:06 [COMMIT] Fix warning in event-top.c Joel Brobecker
2005-11-02 11:03 ` Andrew STUBBS
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox