From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sources.redhat.com
Subject: [COMMIT] Fix warning in event-top.c
Date: Wed, 02 Nov 2005 06:06:00 -0000 [thread overview]
Message-ID: <20051102055523.GD974@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
Currently running gdb_mbuild pretty much for the first time, and
disovering lots of builds failures, mostly because of -Werror. Here
is a fix the one warning in one of the core files. I think the other
ones are in target dependent files.
2005-11-02 Joel Brobecker <brobecker@adacore.com>
* event-top.c (gdb_setup_readline): Add missing type in extern
declaration.
Fixes the following compiler warning:
event-top.c: In function `gdb_setup_readline':
event-top.c:1113: warning: type defaults to `int' in declaration of `batch_silent'
Here is where the variable is defined:
main.c:int batch_silent = 0;
Tested on x86-linux, no regression in the testsuite. I'm committing
this under the obvious fix rule. I think it's pretty obvious.
--
Joel
[-- Attachment #2: event-top.c.diff --]
[-- Type: text/plain, Size: 590 bytes --]
Index: event-top.c
===================================================================
RCS file: /cvs/src/src/gdb/event-top.c,v
retrieving revision 1.41
diff -u -p -r1.41 event-top.c
--- event-top.c 1 Nov 2005 11:09:18 -0000 1.41
+++ event-top.c 2 Nov 2005 05:43:44 -0000
@@ -1110,7 +1110,7 @@ gdb_setup_readline (void)
that the sync setup is ALL done in gdb_init, and we would only
mess it up here. The sync stuff should really go away over
time. */
- extern batch_silent;
+ extern int batch_silent;
if (!batch_silent)
gdb_stdout = stdio_fileopen (stdout);
next reply other threads:[~2005-11-02 5:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 6:06 Joel Brobecker [this message]
2005-11-02 11:03 ` Andrew STUBBS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102055523.GD974@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox