From: Daniel Jacobowitz <drow@false.org>
To: Paul Gilliam <pgilliam@us.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Add vscr register to 'list' of PowerPC vector registers.
Date: Fri, 14 Oct 2005 19:15:00 -0000 [thread overview]
Message-ID: <20051014191504.GA724@nevyn.them.org> (raw)
In-Reply-To: <200510141213.20387.pgilliam@us.ibm.com>
On Fri, Oct 14, 2005 at 12:13:20PM -0700, Paul Gilliam wrote:
> The vscr regisgter was omitted from the if statement in rs6000-tdep.c that decides if a register is a vector register.
> Consiquetly, it was not printed along with the other vector registers using the 'info vector' command.
>
> Two patches follow: the first fixes the problem with the least amount of fuss.
>
> The second adds ppc_vscr_regnum to the gdbarch_tdep struct in ppc-tdep.h and then uses that.
> This version was prompted by this comment in rs6000-tdep.c:
> /* FIXME: jimb/2004-07-15: when we have tdep->ppc_vscr_regnum,
> we can treat this more like the other cases. */
>
> Which should i commit?
You should also try posting patches using a readable diff format :-)
(unified, please, or at least context).
I have no preferences on the actual patch.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-10-14 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 19:11 Paul Gilliam
2005-10-14 19:15 ` Daniel Jacobowitz [this message]
2005-10-14 20:21 ` [COMMIT] " Paul Gilliam
2005-10-14 20:22 ` Daniel Jacobowitz
2005-10-14 20:35 ` Paul Gilliam
2005-10-14 20:41 ` Daniel Jacobowitz
2005-10-18 17:11 ` Kevin Buettner
2005-10-15 4:33 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051014191504.GA724@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=pgilliam@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox