From: Paul Gilliam <pgilliam@us.ibm.com>
To: gdb-patches@sources.redhat.com
Cc: Daniel Jacobowitz <drow@false.org>
Subject: [COMMIT] Add vscr register to 'list' of PowerPC vector registers.
Date: Fri, 14 Oct 2005 20:21:00 -0000 [thread overview]
Message-ID: <200510141323.02754.pgilliam@us.ibm.com> (raw)
In-Reply-To: <20051014191504.GA724@nevyn.them.org>
I went with the least intrusive.
Here is what I comitted: (From 'cvs diff -Nau' this time. Hope this is better. 8-)
2005-10-14 Paul Gilliam <pgilliam@us.ibm.com>
* rs6000-tdep.c (rs6000_register_reggroup_p): Add vscr to test for
vector registers.
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.245
diff -a -u -r1.245 rs6000-tdep.c
--- rs6000-tdep.c 6 Oct 2005 00:22:57 -0000 1.245
+++ rs6000-tdep.c 14 Oct 2005 20:11:02 -0000
@@ -1888,6 +1888,7 @@
|| (tdep->ppc_ev0_regnum >= 0
&& regnum >= tdep->ppc_ev0_regnum
&& regnum < tdep->ppc_ev0_regnum + 32)
+ || regnum == tdep->ppc_vrsave_regnum - 1 /* vscr */
|| regnum == tdep->ppc_vrsave_regnum
|| regnum == tdep->ppc_acc_regnum
|| regnum == tdep->ppc_spefscr_regnum);
On Friday 14 October 2005 12:15, Daniel Jacobowitz wrote:
> On Fri, Oct 14, 2005 at 12:13:20PM -0700, Paul Gilliam wrote:
> > The vscr regisgter was omitted from the if statement in rs6000-tdep.c that decides if a register is a vector register.
> > Consiquetly, it was not printed along with the other vector registers using the 'info vector' command.
> >
> > Two patches follow: the first fixes the problem with the least amount of fuss.
> >
> > The second adds ppc_vscr_regnum to the gdbarch_tdep struct in ppc-tdep.h and then uses that.
> > This version was prompted by this comment in rs6000-tdep.c:
> > /* FIXME: jimb/2004-07-15: when we have tdep->ppc_vscr_regnum,
> > we can treat this more like the other cases. */
> >
> > Which should i commit?
>
> You should also try posting patches using a readable diff format :-)
> (unified, please, or at least context).
>
> I have no preferences on the actual patch.
>
>
next prev parent reply other threads:[~2005-10-14 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 19:11 [PATCH] " Paul Gilliam
2005-10-14 19:15 ` Daniel Jacobowitz
2005-10-14 20:21 ` Paul Gilliam [this message]
2005-10-14 20:22 ` [COMMIT] " Daniel Jacobowitz
2005-10-14 20:35 ` Paul Gilliam
2005-10-14 20:41 ` Daniel Jacobowitz
2005-10-18 17:11 ` Kevin Buettner
2005-10-15 4:33 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510141323.02754.pgilliam@us.ibm.com \
--to=pgilliam@us.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox