From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9634 invoked by alias); 14 Oct 2005 20:21:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9609 invoked by uid 22791); 14 Oct 2005 20:21:22 -0000 Received: from e33.co.us.ibm.com (HELO e33.co.us.ibm.com) (32.97.110.151) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 14 Oct 2005 20:21:22 +0000 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e33.co.us.ibm.com (8.12.11/8.12.11) with ESMTP id j9EKJTJe008771 for ; Fri, 14 Oct 2005 16:19:29 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j9EKLKkF508094 for ; Fri, 14 Oct 2005 14:21:20 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j9EKLKW6020273 for ; Fri, 14 Oct 2005 14:21:20 -0600 Received: from dyn9047022123-009047022095.beaverton.ibm.com (dyn9047022123-009047022095.beaverton.ibm.com [9.47.22.95]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j9EKLJtw020256; Fri, 14 Oct 2005 14:21:20 -0600 From: Paul Gilliam Reply-To: pgilliam@us.ibm.com To: gdb-patches@sources.redhat.com Subject: [COMMIT] Add vscr register to 'list' of PowerPC vector registers. Date: Fri, 14 Oct 2005 20:21:00 -0000 User-Agent: KMail/1.6.2 Cc: Daniel Jacobowitz References: <200510141213.20387.pgilliam@us.ibm.com> <20051014191504.GA724@nevyn.them.org> In-Reply-To: <20051014191504.GA724@nevyn.them.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200510141323.02754.pgilliam@us.ibm.com> X-SW-Source: 2005-10/txt/msg00125.txt.bz2 I went with the least intrusive. Here is what I comitted: (From 'cvs diff -Nau' this time. Hope this is better. 8-) 2005-10-14 Paul Gilliam * rs6000-tdep.c (rs6000_register_reggroup_p): Add vscr to test for vector registers. Index: rs6000-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v retrieving revision 1.245 diff -a -u -r1.245 rs6000-tdep.c --- rs6000-tdep.c 6 Oct 2005 00:22:57 -0000 1.245 +++ rs6000-tdep.c 14 Oct 2005 20:11:02 -0000 @@ -1888,6 +1888,7 @@ || (tdep->ppc_ev0_regnum >= 0 && regnum >= tdep->ppc_ev0_regnum && regnum < tdep->ppc_ev0_regnum + 32) + || regnum == tdep->ppc_vrsave_regnum - 1 /* vscr */ || regnum == tdep->ppc_vrsave_regnum || regnum == tdep->ppc_acc_regnum || regnum == tdep->ppc_spefscr_regnum); On Friday 14 October 2005 12:15, Daniel Jacobowitz wrote: > On Fri, Oct 14, 2005 at 12:13:20PM -0700, Paul Gilliam wrote: > > The vscr regisgter was omitted from the if statement in rs6000-tdep.c that decides if a register is a vector register. > > Consiquetly, it was not printed along with the other vector registers using the 'info vector' command. > > > > Two patches follow: the first fixes the problem with the least amount of fuss. > > > > The second adds ppc_vscr_regnum to the gdbarch_tdep struct in ppc-tdep.h and then uses that. > > This version was prompted by this comment in rs6000-tdep.c: > > /* FIXME: jimb/2004-07-15: when we have tdep->ppc_vscr_regnum, > > we can treat this more like the other cases. */ > > > > Which should i commit? > > You should also try posting patches using a readable diff format :-) > (unified, please, or at least context). > > I have no preferences on the actual patch. > >