From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23074 invoked by alias); 14 Oct 2005 19:15:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23064 invoked by uid 22791); 14 Oct 2005 19:15:06 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 14 Oct 2005 19:15:06 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EQV1E-0000De-7B; Fri, 14 Oct 2005 15:15:04 -0400 Date: Fri, 14 Oct 2005 19:15:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add vscr register to 'list' of PowerPC vector registers. Message-ID: <20051014191504.GA724@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200510141213.20387.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510141213.20387.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-10/txt/msg00124.txt.bz2 On Fri, Oct 14, 2005 at 12:13:20PM -0700, Paul Gilliam wrote: > The vscr regisgter was omitted from the if statement in rs6000-tdep.c that decides if a register is a vector register. > Consiquetly, it was not printed along with the other vector registers using the 'info vector' command. > > Two patches follow: the first fixes the problem with the least amount of fuss. > > The second adds ppc_vscr_regnum to the gdbarch_tdep struct in ppc-tdep.h and then uses that. > This version was prompted by this comment in rs6000-tdep.c: > /* FIXME: jimb/2004-07-15: when we have tdep->ppc_vscr_regnum, > we can treat this more like the other cases. */ > > Which should i commit? You should also try posting patches using a readable diff format :-) (unified, please, or at least context). I have no preferences on the actual patch. -- Daniel Jacobowitz CodeSourcery, LLC