Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Bob Rossi <bob@brasko.net>
To: gdb-patches@sources.redhat.com
Subject: Re: Fully anchor mi_gdb_test expected results.
Date: Tue, 27 Sep 2005 22:41:00 -0000	[thread overview]
Message-ID: <20050927224040.GA13269@white> (raw)
In-Reply-To: <20050926014218.GE22284@nevyn.them.org>

On Sun, Sep 25, 2005 at 09:42:18PM -0400, Daniel Jacobowitz wrote:
> On Tue, Sep 20, 2005 at 09:25:39PM -0400, Bob Rossi wrote:
> > This has gone away in the new patch, tell me what you think. I had to
> > modify several testcases, but only to get them to match the begin
> > anchor. This of course passes the testsuite. 
> > 
> > With this change I think I'm only several lines away from syntax
> > checking the testsuite. I'll try it out to see if anything's changed
> > recently.
> > 
> > Bob Rossi
> > 
> > RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
> > +2005-08-03  Bob Rossi  <bob@brasko.net>
> > +
> > +	* gdb.mi/mi-disassemble.exp, gdb.mi/mi2-disassemble.exp: Remove .* 
> > +	from test.  Escape the | in mi_gdb_test call.
> > +	* gdb.mi/mi-basics.exp, gdb.mi/mi-cli.exp, gdb.mi/mi-disassemble.exp,
> > +	gdb.mi/mi-pthreads.exp, gdb.mi/mi-stack.exp, gdb.mi/mi2-basics.exp,
> > +	gdb.mi/mi2-cli.exp, gdb.mi/mi2-disassemble.exp,
> > +	gdb.mi/mi2-pthreads.exp, gdb.mi/mi2-stack.exp: Add extra details to
> > +	expected regex's in mi_gdb_test calls.
> > +	* lib/mi-support.exp: Remove arbitrary .* from tests.
> > +	(mi_gdb_test): Add string_regex variable. Add anchor to main -re.
> > +	Fully anchor GDB/MI expected results in mi_gdb_test.
> > +	* lib/gdb.exp (string_to_regexp): Escape the ] character.
> > +	* gdb.base/sizeof.exp: Remove escape character. Correct test.
> 
> Looks good to me.  This is OK.  Could you make sure to update the
> copyright years in any of these files which weren't changed in 2005? 
> Only one I see offhand is sizeof.exp but I did not check them all.

Thanks Daniel, I appreciate it. I added the copyright dates and
committed the patch. Also, I thought it might be nice to hear, the
MI is still syntactically correct!

This means I can continue nicely, without any distractions at this
point.

Thanks,
Bob Rossi


  reply	other threads:[~2005-09-27 22:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-04  2:50 Bob Rossi
2005-08-04  4:11 ` Daniel Jacobowitz
2005-08-04 14:09   ` Bob Rossi
2005-08-04 14:18     ` Daniel Jacobowitz
2005-08-04 14:26       ` Bob Rossi
2005-08-04 14:33         ` Daniel Jacobowitz
2005-08-04 20:37           ` Bob Rossi
2005-08-04 20:48             ` Bob Rossi
2005-08-04 20:58               ` Daniel Jacobowitz
2005-08-04 21:17                 ` Bob Rossi
2005-08-04 20:57             ` Daniel Jacobowitz
2005-08-04 21:18               ` Bob Rossi
2005-08-04 22:40                 ` Bob Rossi
2005-08-04 22:43                   ` Daniel Jacobowitz
2005-08-04 23:50                     ` Bob Rossi
2005-09-18  1:32                       ` Daniel Jacobowitz
2005-09-18  2:10                         ` Bob Rossi
2005-09-21  1:26                         ` Bob Rossi
2005-09-26  1:42                           ` Daniel Jacobowitz
2005-09-27 22:41                             ` Bob Rossi [this message]
2005-08-04 14:34         ` Bob Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050927224040.GA13269@white \
    --to=bob@brasko.net \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox