From: Bob Rossi <bob@brasko.net>
To: gdb-patches@sources.redhat.com
Subject: Re: Fully anchor mi_gdb_test expected results.
Date: Thu, 04 Aug 2005 14:26:00 -0000 [thread overview]
Message-ID: <20050804142601.GC4054@white> (raw)
In-Reply-To: <20050804141750.GA11536@nevyn.them.org>
> > which simply allows any data at the beggining of the match. So I could
> > easily modify an MI command to output "HAHAHA, YOU CAN'T TEST ME", as
> > the first thing it outputs, and it would go unnoticed in the
> > testsuite. Probably the reason this could not have been done before is
> > because the MI input command was being echo'd back, and it would be
> > complicated to match that data.
>
> I am suggesting anchoring the pattern with a copy of what you expect to
> be echoed. We already have code to escape a string into a regex. We
> know what we sent to GDB.
I originally tried this, but failed because I did *not* know how to
escape a string into a regex. Is there a function written that does
this? I'll try it.
> If you think that's too much trouble, could you alternatively try "stty
> -echo" in expect, rather than send_gdb "shell stty -echo"?
This was the original path I went down. However, I couldn't figure out
what the heck remote_spawn is. There is no documentation anywere (that I
could find). So, does remote_spawn call spawn? Does it take the same
arguments as spawn?
> > - Make sure every test has the GDB expected pattern be the absolute
> > beginning of the MI output command. Then I could assume in the
> > general purpose match that the pattern was the beggining. It
> > would look something like this,
> > -re "^.*($pattern\[\r\n\]+$mi_gdb_prompt\[ \]*)$" {
> > I don't like this approach because it makes the testcase do
> > specific things in order to make sure that the syntax checking
> > was done properly.
>
> I've got no idea what you mean by this, but anchoring .* at the front
> of a pattern doesn't accomplish anything!
It doesn't matter anyways, if you like the idea of the 2 above
approaches.
Thanks,
Bob Rossi
next prev parent reply other threads:[~2005-08-04 14:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-04 2:50 Bob Rossi
2005-08-04 4:11 ` Daniel Jacobowitz
2005-08-04 14:09 ` Bob Rossi
2005-08-04 14:18 ` Daniel Jacobowitz
2005-08-04 14:26 ` Bob Rossi [this message]
2005-08-04 14:33 ` Daniel Jacobowitz
2005-08-04 20:37 ` Bob Rossi
2005-08-04 20:48 ` Bob Rossi
2005-08-04 20:58 ` Daniel Jacobowitz
2005-08-04 21:17 ` Bob Rossi
2005-08-04 20:57 ` Daniel Jacobowitz
2005-08-04 21:18 ` Bob Rossi
2005-08-04 22:40 ` Bob Rossi
2005-08-04 22:43 ` Daniel Jacobowitz
2005-08-04 23:50 ` Bob Rossi
2005-09-18 1:32 ` Daniel Jacobowitz
2005-09-18 2:10 ` Bob Rossi
2005-09-21 1:26 ` Bob Rossi
2005-09-26 1:42 ` Daniel Jacobowitz
2005-09-27 22:41 ` Bob Rossi
2005-08-04 14:34 ` Bob Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050804142601.GC4054@white \
--to=bob@brasko.net \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox