From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26840 invoked by alias); 4 Aug 2005 14:26:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26276 invoked by uid 22791); 4 Aug 2005 14:26:04 -0000 Received: from centrmmtao05vip.cox.net (HELO centrmmtao05.cox.net) (68.1.16.143) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 04 Aug 2005 14:26:04 +0000 Received: from white ([68.9.64.121]) by centrmmtao05.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050804142547.NPBQ19684.centrmmtao05.cox.net@white> for ; Thu, 4 Aug 2005 10:25:47 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1E0gfZ-000175-00 for ; Thu, 04 Aug 2005 10:26:01 -0400 Date: Thu, 04 Aug 2005 14:26:00 -0000 From: Bob Rossi To: gdb-patches@sources.redhat.com Subject: Re: Fully anchor mi_gdb_test expected results. Message-ID: <20050804142601.GC4054@white> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050804025045.GC32108@white> <20050804041121.GB29482@nevyn.them.org> <20050804140937.GB4054@white> <20050804141750.GA11536@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050804141750.GA11536@nevyn.them.org> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-08/txt/msg00067.txt.bz2 > > which simply allows any data at the beggining of the match. So I could > > easily modify an MI command to output "HAHAHA, YOU CAN'T TEST ME", as > > the first thing it outputs, and it would go unnoticed in the > > testsuite. Probably the reason this could not have been done before is > > because the MI input command was being echo'd back, and it would be > > complicated to match that data. > > I am suggesting anchoring the pattern with a copy of what you expect to > be echoed. We already have code to escape a string into a regex. We > know what we sent to GDB. I originally tried this, but failed because I did *not* know how to escape a string into a regex. Is there a function written that does this? I'll try it. > If you think that's too much trouble, could you alternatively try "stty > -echo" in expect, rather than send_gdb "shell stty -echo"? This was the original path I went down. However, I couldn't figure out what the heck remote_spawn is. There is no documentation anywere (that I could find). So, does remote_spawn call spawn? Does it take the same arguments as spawn? > > - Make sure every test has the GDB expected pattern be the absolute > > beginning of the MI output command. Then I could assume in the > > general purpose match that the pattern was the beggining. It > > would look something like this, > > -re "^.*($pattern\[\r\n\]+$mi_gdb_prompt\[ \]*)$" { > > I don't like this approach because it makes the testcase do > > specific things in order to make sure that the syntax checking > > was done properly. > > I've got no idea what you mean by this, but anchoring .* at the front > of a pattern doesn't accomplish anything! It doesn't matter anyways, if you like the idea of the 2 above approaches. Thanks, Bob Rossi