From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18512 invoked by alias); 27 Sep 2005 22:41:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18479 invoked by uid 22791); 27 Sep 2005 22:40:49 -0000 Received: from eastrmmtao05.cox.net (HELO eastrmmtao05.cox.net) (68.230.240.34) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 27 Sep 2005 22:40:49 +0000 Received: from white ([68.9.64.121]) by eastrmmtao05.cox.net (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP id <20050927224047.FJEA28234.eastrmmtao05.cox.net@white> for ; Tue, 27 Sep 2005 18:40:47 -0400 Received: from bob by white with local (Exim 3.36 #1 (Debian)) id 1EKO7t-0003Uq-00 for ; Tue, 27 Sep 2005 18:40:41 -0400 Date: Tue, 27 Sep 2005 22:41:00 -0000 From: Bob Rossi To: gdb-patches@sources.redhat.com Subject: Re: Fully anchor mi_gdb_test expected results. Message-ID: <20050927224040.GA13269@white> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050804143238.GA11996@nevyn.them.org> <20050804203704.GA4472@white> <20050804205747.GA22030@nevyn.them.org> <20050804211834.GD4472@white> <20050804224044.GB4931@white> <20050804224351.GA25174@nevyn.them.org> <20050804234959.GC4931@white> <20050918013154.GR8777@nevyn.them.org> <20050921012539.GA14775@white> <20050926014218.GE22284@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050926014218.GE22284@nevyn.them.org> User-Agent: Mutt/1.5.9i X-SW-Source: 2005-09/txt/msg00261.txt.bz2 On Sun, Sep 25, 2005 at 09:42:18PM -0400, Daniel Jacobowitz wrote: > On Tue, Sep 20, 2005 at 09:25:39PM -0400, Bob Rossi wrote: > > This has gone away in the new patch, tell me what you think. I had to > > modify several testcases, but only to get them to match the begin > > anchor. This of course passes the testsuite. > > > > With this change I think I'm only several lines away from syntax > > checking the testsuite. I'll try it out to see if anything's changed > > recently. > > > > Bob Rossi > > > > RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v > > +2005-08-03 Bob Rossi > > + > > + * gdb.mi/mi-disassemble.exp, gdb.mi/mi2-disassemble.exp: Remove .* > > + from test. Escape the | in mi_gdb_test call. > > + * gdb.mi/mi-basics.exp, gdb.mi/mi-cli.exp, gdb.mi/mi-disassemble.exp, > > + gdb.mi/mi-pthreads.exp, gdb.mi/mi-stack.exp, gdb.mi/mi2-basics.exp, > > + gdb.mi/mi2-cli.exp, gdb.mi/mi2-disassemble.exp, > > + gdb.mi/mi2-pthreads.exp, gdb.mi/mi2-stack.exp: Add extra details to > > + expected regex's in mi_gdb_test calls. > > + * lib/mi-support.exp: Remove arbitrary .* from tests. > > + (mi_gdb_test): Add string_regex variable. Add anchor to main -re. > > + Fully anchor GDB/MI expected results in mi_gdb_test. > > + * lib/gdb.exp (string_to_regexp): Escape the ] character. > > + * gdb.base/sizeof.exp: Remove escape character. Correct test. > > Looks good to me. This is OK. Could you make sure to update the > copyright years in any of these files which weren't changed in 2005? > Only one I see offhand is sizeof.exp but I did not check them all. Thanks Daniel, I appreciate it. I added the copyright dates and committed the patch. Also, I thought it might be nice to hear, the MI is still syntactically correct! This means I can continue nicely, without any distractions at this point. Thanks, Bob Rossi