Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <me@cgf.cx>
To: Dave Murphy <wintermute2k4@ntlworld.com>,
	gdb-patches@sources.redhat.com, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] Build arm-elf-gdb on mingw host
Date: Mon, 26 Sep 2005 14:09:00 -0000	[thread overview]
Message-ID: <20050926140841.GB17370@trixie.casa.cgf.cx> (raw)
In-Reply-To: <20050926132325.GA1219@nevyn.them.org>

On Mon, Sep 26, 2005 at 09:23:26AM -0400, Daniel Jacobowitz wrote:
>On Mon, Sep 26, 2005 at 05:46:17AM +0100, Dave Murphy wrote:
>> Sorry, I should have said that under mingw/msys files read in text mode 
>> have line endings converted. There are numerous places in chew.c where 
>> it checks for a newline character with expressions like "while (at (tos, 
>> idx) == '\n')", see skip_white_and_stars(src,  idx), 
>> strip_trailing_newlines(),  remove_noncomments (src, dst), 
>> outputdots(),  courierize(),  bulletize(), copy_past_newline (ptr, idx, 
>> dst), kill_bogus_lines(), indent(), skip_past_newline () and  nextword 
>> (string, word). It seemed easier to just read the input files as binary 
>> and suppress the conversion rather than make all the code deal with the 
>> "/r/n" sequence.
>
>I'm afraid this explanation doesn't leave me any more enlightened.  Are
>you saying that opening files in text mode, in mingw, produces \r\n in
>the program view if there was originally just a \n?

I think I get it.  This patch just modifies chew so that it always
outputs '\n'.  Then you see '\n' on input no matter what.

Would it be possible to just link with binmode.o under mingw (and cygwin for
that matter)?

cgf


  reply	other threads:[~2005-09-26 14:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-25 23:23 Dave Murphy
2005-09-26  3:46 ` Eli Zaretskii
2005-09-26  3:59   ` Daniel Jacobowitz
2005-09-26  4:46     ` Dave Murphy
2005-09-26 13:23       ` Daniel Jacobowitz
2005-09-26 14:09         ` Christopher Faylor [this message]
2005-09-26 14:14           ` Daniel Jacobowitz
2005-09-26 14:26             ` Christopher Faylor
2005-09-26 14:31               ` Daniel Jacobowitz
2005-09-26 15:41                 ` Christopher Faylor
2005-09-26 19:18                 ` Eli Zaretskii
2006-04-08 20:21               ` Daniel Jacobowitz
2006-04-10 16:51                 ` Christopher Faylor
2006-04-10 16:58                   ` Daniel Jacobowitz
2005-09-26 19:16             ` Eli Zaretskii
2005-09-27  2:02               ` Christopher Faylor
2005-09-26 19:13           ` Eli Zaretskii
2005-09-26 19:08       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050926140841.GB17370@trixie.casa.cgf.cx \
    --to=me@cgf.cx \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=wintermute2k4@ntlworld.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox