From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30252 invoked by alias); 26 Sep 2005 14:09:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29898 invoked by uid 22791); 26 Sep 2005 14:08:43 -0000 Received: from c-24-61-23-223.hsd1.ma.comcast.net (HELO cgf.cx) (24.61.23.223) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 26 Sep 2005 14:08:43 +0000 Received: by cgf.cx (Postfix, from userid 201) id BC5E213C08D; Mon, 26 Sep 2005 14:08:41 +0000 (UTC) Date: Mon, 26 Sep 2005 14:09:00 -0000 From: Christopher Faylor To: Dave Murphy , gdb-patches@sources.redhat.com, Eli Zaretskii Subject: Re: [patch] Build arm-elf-gdb on mingw host Message-ID: <20050926140841.GB17370@trixie.casa.cgf.cx> Mail-Followup-To: Dave Murphy , gdb-patches@sources.redhat.com, Eli Zaretskii References: <4337317B.3050300@ntlworld.com> <20050926035937.GA24565@nevyn.them.org> <43377D19.7050505@ntlworld.com> <20050926132325.GA1219@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050926132325.GA1219@nevyn.them.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-09/txt/msg00222.txt.bz2 On Mon, Sep 26, 2005 at 09:23:26AM -0400, Daniel Jacobowitz wrote: >On Mon, Sep 26, 2005 at 05:46:17AM +0100, Dave Murphy wrote: >> Sorry, I should have said that under mingw/msys files read in text mode >> have line endings converted. There are numerous places in chew.c where >> it checks for a newline character with expressions like "while (at (tos, >> idx) == '\n')", see skip_white_and_stars(src, idx), >> strip_trailing_newlines(), remove_noncomments (src, dst), >> outputdots(), courierize(), bulletize(), copy_past_newline (ptr, idx, >> dst), kill_bogus_lines(), indent(), skip_past_newline () and nextword >> (string, word). It seemed easier to just read the input files as binary >> and suppress the conversion rather than make all the code deal with the >> "/r/n" sequence. > >I'm afraid this explanation doesn't leave me any more enlightened. Are >you saying that opening files in text mode, in mingw, produces \r\n in >the program view if there was originally just a \n? I think I get it. This patch just modifies chew so that it always outputs '\n'. Then you see '\n' on input no matter what. Would it be possible to just link with binmode.o under mingw (and cygwin for that matter)? cgf