Re: [patch] Build arm-elf-gdb on mingw host

[Daniel Jacobowitz <drow@false.org>]

On Mon, Sep 26, 2005 at 06:46:10AM +0300, Eli Zaretskii wrote:
> > Date: Mon, 26 Sep 2005 00:23:39 +0100
> > From: Dave Murphy <wintermute2k4@ntlworld.com>
> > 
> > When building the bfd/doc directory under mingw/msys chew.c converts 
> > line endings to crlf.  I've patched so the files are read as binary, 
> > preventing this conversion.
> 
> Why?  What's wrong with having the output from chew have CRLF line
> endings on Windows?

Yeah, I'm wondering about this too.

> > SIGTRAP isn't defined in the MinGW headers, I patched remote-sim.c to 
> > define this if it's not defined.
> 
> I don't think this is a good idea.  It is much better (and widely
> practiced) to #ifdef away portions of code that use SIGTRAP, like
> this:
> 
>     #ifdef SIGTRAP
>     ... code that depends on SIGTRAP ...
>     #endif

In this case, unfortunately, it's a bit more complicated to fix.  You
can find a similar workaround patch from Paul Brook in the archives,
and my discussion (with Mark?) about it.  The gdb<->sim interface uses
"signals", meaning the host signal numbers.  And without SIGTRAP we
can't step or breakpoint.  Thus, a lot of files in sim already define
SIGTRAP.

They ought to be converted to the relatively new "gdb/signals.h" header
in include/, but the simulators are also concerned with actual host
signals in places, so a simple search and replace isn't right either.
It's going to take a little investigation to fix this properly.

-- 
Daniel Jacobowitz
CodeSourcery, LLC