From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11012 invoked by alias); 26 Sep 2005 03:59:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10976 invoked by uid 22791); 26 Sep 2005 03:59:40 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 26 Sep 2005 03:59:40 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EJk9R-0006Ql-27; Sun, 25 Sep 2005 23:59:37 -0400 Date: Mon, 26 Sep 2005 03:59:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: Dave Murphy , gdb-patches@sources.redhat.com Subject: Re: [patch] Build arm-elf-gdb on mingw host Message-ID: <20050926035937.GA24565@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , Dave Murphy , gdb-patches@sources.redhat.com References: <4337317B.3050300@ntlworld.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-09/txt/msg00215.txt.bz2 On Mon, Sep 26, 2005 at 06:46:10AM +0300, Eli Zaretskii wrote: > > Date: Mon, 26 Sep 2005 00:23:39 +0100 > > From: Dave Murphy > > > > When building the bfd/doc directory under mingw/msys chew.c converts > > line endings to crlf. I've patched so the files are read as binary, > > preventing this conversion. > > Why? What's wrong with having the output from chew have CRLF line > endings on Windows? Yeah, I'm wondering about this too. > > SIGTRAP isn't defined in the MinGW headers, I patched remote-sim.c to > > define this if it's not defined. > > I don't think this is a good idea. It is much better (and widely > practiced) to #ifdef away portions of code that use SIGTRAP, like > this: > > #ifdef SIGTRAP > ... code that depends on SIGTRAP ... > #endif In this case, unfortunately, it's a bit more complicated to fix. You can find a similar workaround patch from Paul Brook in the archives, and my discussion (with Mark?) about it. The gdb<->sim interface uses "signals", meaning the host signal numbers. And without SIGTRAP we can't step or breakpoint. Thus, a lot of files in sim already define SIGTRAP. They ought to be converted to the relatively new "gdb/signals.h" header in include/, but the simulators are also concerned with actual host signals in places, so a simple search and replace isn't right either. It's going to take a little investigation to fix this properly. -- Daniel Jacobowitz CodeSourcery, LLC