Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Gilliam <pgilliam@us.ibm.com>
To: gdb-patches@sources.redhat.com
Subject: [commit] "get rid of info powerpc"
Date: Mon, 19 Sep 2005 17:50:00 -0000	[thread overview]
Message-ID: <200509191049.15893.pgilliam@us.ibm.com> (raw)
In-Reply-To: <20050916124719.5617a50c@ironwood.lan>

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

Attached is the patch I committed.  It just gets rid of the 'info powerpc' command prefix and patches the test
to use 'info vector' instead.

One question though:  I made an entry in the src/gdb/ChangeLog for the change to src/rs6000-tdep.c and one
in the src/gdb/testsuite/ChangeLog for for the change to altivec-regs.exp.  Was that the right way to do it?
Should I just have made one ChangeLog entry in src/gdb/ChangeLog?

-=# Paul #=-

On Friday 16 September 2005 12:47, Kevin Buettner wrote:
> On Fri, 16 Sep 2005 11:50:12 -0700
> Paul Gilliam <pgilliam@us.ibm.com> wrote:
> 
> > Ok, I agree.
> > 
> > Door 3 it is:  Do I need anymore more approvals to commit?
> 
> If I'm not mistaken, Daniel suggested just removing the "info powerpc"
> command.  Your no_more_altivec.patch does a bit more than this in that
> it deprecates this command as well.
> 
> I'm comfortable with a patch that removes the "info powerpc" command
> and updates the testsuite to use "info vector".  Consider such a patch
> as preapproved.  (But do post it to the list after committing it.)
> 
> Thanks!
> 
> Kevin
> 
> 

[-- Attachment #2: elide_info_powerpc.patch --]
[-- Type: text/x-diff, Size: 1655 bytes --]

2005-09-19  Paul Gilliam  <pgilliam@us.ibm.com>

	* rs6000-tdep.c (_initialize_rs6000_tdep): Get rid of the unused
	'info powerpc' command prefix.
	* gdb.arch/altivec-regs.exp (info powerpc altivec): Replace the 'info
	powerpc altivec' test with an almost identical 'info vector' test.

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.242
diff -a -u -r1.242 rs6000-tdep.c
--- rs6000-tdep.c	1 Sep 2005 18:09:41 -0000	1.242
+++ rs6000-tdep.c	19 Sep 2005 17:11:10 -0000
@@ -3415,9 +3415,4 @@
 {
   gdbarch_register (bfd_arch_rs6000, rs6000_gdbarch_init, rs6000_dump_tdep);
   gdbarch_register (bfd_arch_powerpc, rs6000_gdbarch_init, rs6000_dump_tdep);
-
-  /* Add root prefix command for "info powerpc" commands */
-  add_prefix_cmd ("powerpc", class_info, rs6000_info_powerpc_command,
-		  _("Various POWERPC info specific commands."),
-		  &info_powerpc_cmdlist, "info powerpc ", 0, &infolist);
 }
Index: testsuite/gdb.arch/altivec-regs.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/altivec-regs.exp,v
retrieving revision 1.6
diff -a -u -r1.6 altivec-regs.exp
--- testsuite/gdb.arch/altivec-regs.exp	13 Sep 2005 23:13:50 -0000	1.6
+++ testsuite/gdb.arch/altivec-regs.exp	19 Sep 2005 17:11:10 -0000
@@ -140,8 +140,8 @@
          append pattern$i $vector_register
 }
 
-send_gdb "info powerpc altivec\n"
-gdb_expect_list "info powerpc altivec" ".*$gdb_prompt $" {
+send_gdb "info vector\n"
+gdb_expect_list "info vector" ".*$gdb_prompt $" {
 [$pattern0]
 [$pattern1]
 [$pattern2]

  reply	other threads:[~2005-09-19 17:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-09 23:32 [RFC] "info powerpc" Paul Gilliam
2005-09-15  0:11 ` [PATCH]*3 " Paul Gilliam
2005-09-15  3:34   ` Eli Zaretskii
2005-09-15 19:06     ` [DOC PATCH] " Paul Gilliam
2005-09-16 10:26       ` Eli Zaretskii
2005-09-15 19:18   ` Mark Kettenis
2005-09-16 13:56   ` Daniel Jacobowitz
2005-09-16 17:45     ` Kevin Buettner
2005-09-16 18:51     ` Paul Gilliam
2005-09-16 19:40       ` Mark Kettenis
2005-09-16 19:47       ` Kevin Buettner
2005-09-19 17:50         ` Paul Gilliam [this message]
2005-09-19 18:09           ` [commit] "get rid of info powerpc" Daniel Jacobowitz
2005-09-20 20:05             ` Paul Gilliam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200509191049.15893.pgilliam@us.ibm.com \
    --to=pgilliam@us.ibm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox