From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29286 invoked by alias); 19 Sep 2005 17:50:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29089 invoked by uid 22791); 19 Sep 2005 17:49:21 -0000 Received: from e33.co.us.ibm.com (HELO e33.co.us.ibm.com) (32.97.110.131) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 19 Sep 2005 17:49:21 +0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j8JHn6bg370632 for ; Mon, 19 Sep 2005 13:49:09 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j8JHnar3545322 for ; Mon, 19 Sep 2005 11:49:36 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j8JHn5DJ006225 for ; Mon, 19 Sep 2005 11:49:05 -0600 Received: from dyn9047022123-009047022095.beaverton.ibm.com (dyn9047022123-009047022095.beaverton.ibm.com [9.47.22.95]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j8JHn5qs006209 for ; Mon, 19 Sep 2005 11:49:05 -0600 From: Paul Gilliam Reply-To: pgilliam@us.ibm.com To: gdb-patches@sources.redhat.com Subject: [commit] "get rid of info powerpc" Date: Mon, 19 Sep 2005 17:50:00 -0000 User-Agent: KMail/1.6.2 References: <200509091633.02630.pgilliam@us.ibm.com> <200509161150.12329.pgilliam@us.ibm.com> <20050916124719.5617a50c@ironwood.lan> In-Reply-To: <20050916124719.5617a50c@ironwood.lan> MIME-Version: 1.0 Content-Disposition: inline Content-Type: Multipart/Mixed; boundary="Boundary-00=_bovLDvbe8cdc9An" Message-Id: <200509191049.15893.pgilliam@us.ibm.com> X-SW-Source: 2005-09/txt/msg00169.txt.bz2 --Boundary-00=_bovLDvbe8cdc9An Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 1098 Attached is the patch I committed. It just gets rid of the 'info powerpc' command prefix and patches the test to use 'info vector' instead. One question though: I made an entry in the src/gdb/ChangeLog for the change to src/rs6000-tdep.c and one in the src/gdb/testsuite/ChangeLog for for the change to altivec-regs.exp. Was that the right way to do it? Should I just have made one ChangeLog entry in src/gdb/ChangeLog? -=# Paul #=- On Friday 16 September 2005 12:47, Kevin Buettner wrote: > On Fri, 16 Sep 2005 11:50:12 -0700 > Paul Gilliam wrote: > > > Ok, I agree. > > > > Door 3 it is: Do I need anymore more approvals to commit? > > If I'm not mistaken, Daniel suggested just removing the "info powerpc" > command. Your no_more_altivec.patch does a bit more than this in that > it deprecates this command as well. > > I'm comfortable with a patch that removes the "info powerpc" command > and updates the testsuite to use "info vector". Consider such a patch > as preapproved. (But do post it to the list after committing it.) > > Thanks! > > Kevin > > --Boundary-00=_bovLDvbe8cdc9An Content-Type: text/x-diff; charset="iso-8859-1"; name="elide_info_powerpc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="elide_info_powerpc.patch" Content-length: 1655 2005-09-19 Paul Gilliam * rs6000-tdep.c (_initialize_rs6000_tdep): Get rid of the unused 'info powerpc' command prefix. * gdb.arch/altivec-regs.exp (info powerpc altivec): Replace the 'info powerpc altivec' test with an almost identical 'info vector' test. Index: rs6000-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v retrieving revision 1.242 diff -a -u -r1.242 rs6000-tdep.c --- rs6000-tdep.c 1 Sep 2005 18:09:41 -0000 1.242 +++ rs6000-tdep.c 19 Sep 2005 17:11:10 -0000 @@ -3415,9 +3415,4 @@ { gdbarch_register (bfd_arch_rs6000, rs6000_gdbarch_init, rs6000_dump_tdep); gdbarch_register (bfd_arch_powerpc, rs6000_gdbarch_init, rs6000_dump_tdep); - - /* Add root prefix command for "info powerpc" commands */ - add_prefix_cmd ("powerpc", class_info, rs6000_info_powerpc_command, - _("Various POWERPC info specific commands."), - &info_powerpc_cmdlist, "info powerpc ", 0, &infolist); } Index: testsuite/gdb.arch/altivec-regs.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/altivec-regs.exp,v retrieving revision 1.6 diff -a -u -r1.6 altivec-regs.exp --- testsuite/gdb.arch/altivec-regs.exp 13 Sep 2005 23:13:50 -0000 1.6 +++ testsuite/gdb.arch/altivec-regs.exp 19 Sep 2005 17:11:10 -0000 @@ -140,8 +140,8 @@ append pattern$i $vector_register } -send_gdb "info powerpc altivec\n" -gdb_expect_list "info powerpc altivec" ".*$gdb_prompt $" { +send_gdb "info vector\n" +gdb_expect_list "info vector" ".*$gdb_prompt $" { [$pattern0] [$pattern1] [$pattern2] --Boundary-00=_bovLDvbe8cdc9An--