Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: wilson@specifix.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] fix gcc4 error for freebsd target
Date: Wed, 31 Aug 2005 20:08:00 -0000	[thread overview]
Message-ID: <200508311937.j7VJb6dt014705@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <1125515044.21922.12.camel@aretha.corp.specifix.com> (message from James E Wilson on Wed, 31 Aug 2005 12:04:04 -0700)

> From: James E Wilson <wilson@specifix.com>
> Date: Wed, 31 Aug 2005 12:04:04 -0700
> 
> On an i386-freebsd4.10 machine, using gcc-4.0.1 to compile gdb-6.3, I
> get a compiler error.  The same problem still exists on gdb mainline.
> 
> ../../gdb-6.3/gdb/i386fbsd-tdep.c:48: error: static declaration of
> '386fbsd_sc_reg_offset' follows non-static declaration
> ../../gdb-6.3/gdb/i386-tdep.h:190: error: previous declaration of
> 'i386fbsd_sc_reg_offset' was here

Duh!

> The fix is trivial.  We just need to delete the static keyword from the
> i386fbsd_sc_reg_offset definition in i386fbsd-tdep.c.
> 
> I've attached the patch for gdb-6.3, which also applies with a small
> offset to mainline.  OK for mainline?  Do you want it on the gdb-6.3
> branch also perhaps?

Please apply to mainline.  The gdb 6.3 branch is dead, so there's no
point in adding this patch there too.

Thanks,

Mark


  reply	other threads:[~2005-08-31 19:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-31 19:37 James E Wilson
2005-08-31 20:08 ` Mark Kettenis [this message]
2005-08-31 20:17   ` James E Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200508311937.j7VJb6dt014705@elgar.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=wilson@specifix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox