Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: James E Wilson <wilson@specifix.com>
To: gdb-patches@sourceware.org
Subject: [patch] fix gcc4 error for freebsd target
Date: Wed, 31 Aug 2005 19:37:00 -0000	[thread overview]
Message-ID: <1125515044.21922.12.camel@aretha.corp.specifix.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

On an i386-freebsd4.10 machine, using gcc-4.0.1 to compile gdb-6.3, I
get a compiler error.  The same problem still exists on gdb mainline.

../../gdb-6.3/gdb/i386fbsd-tdep.c:48: error: static declaration of
‘i386fbsd_sc_reg_offset’ follows non-static declaration
../../gdb-6.3/gdb/i386-tdep.h:190: error: previous declaration of
‘i386fbsd_sc_reg_offset’ was here

The fix is trivial.  We just need to delete the static keyword from the
i386fbsd_sc_reg_offset definition in i386fbsd-tdep.c.

I've attached the patch for gdb-6.3, which also applies with a small
offset to mainline.  OK for mainline?  Do you want it on the gdb-6.3
branch also perhaps?
-- 
Jim Wilson, GNU Tools Support, http://www.specifix.com

[-- Attachment #2: patch.fbsd.static --]
[-- Type: text/plain, Size: 897 bytes --]

2005-08-31  Jim Wilson  <wilson@specifix.com>

	* i386fbsd-nat.c (i386fbsd_sc_reg_offset): Make it non-static.

Index: i386fbsd-tdep.c
===================================================================
RCS file: /services/cvs/cvsroot/gnusense/gdb/gdb/i386fbsd-tdep.c,v
retrieving revision 1.1.1.1
diff -p -r1.1.1.1 i386fbsd-tdep.c
*** i386fbsd-tdep.c	8 Jul 2004 13:06:48 -0000	1.1.1.1
--- i386fbsd-tdep.c	31 Aug 2005 18:27:58 -0000
*************** CORE_ADDR i386fbsd_sigtramp_start_addr =
*** 45,51 ****
  CORE_ADDR i386fbsd_sigtramp_end_addr = 0xbfbfdff0;
  
  /* From <machine/signal.h>.  */
! static int i386fbsd_sc_reg_offset[] =
  {
    8 + 14 * 4,			/* %eax */
    8 + 13 * 4,			/* %ecx */
--- 45,51 ----
  CORE_ADDR i386fbsd_sigtramp_end_addr = 0xbfbfdff0;
  
  /* From <machine/signal.h>.  */
! int i386fbsd_sc_reg_offset[] =
  {
    8 + 14 * 4,			/* %eax */
    8 + 13 * 4,			/* %ecx */

             reply	other threads:[~2005-08-31 19:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-31 19:37 James E Wilson [this message]
2005-08-31 20:08 ` Mark Kettenis
2005-08-31 20:17   ` James E Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1125515044.21922.12.camel@aretha.corp.specifix.com \
    --to=wilson@specifix.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox